Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate app label causes helm install failure #579

Closed
adamrlynch opened this issue Oct 27, 2023 · 1 comment · Fixed by #582
Closed

Duplicate app label causes helm install failure #579

adamrlynch opened this issue Oct 27, 2023 · 1 comment · Fixed by #582

Comments

@adamrlynch
Copy link

Describe the Issue
When installing the virtual kubelet chart using Flux v2 there is a duplicate label, apps, that gets created and fails to install. Installation through helm cli is ok as helm is more forgiving than Flux, however, it should be expected that the helm chart wouldn't have duplicate values, which violate YAML syntax.
Steps To Reproduce

  1. Run helm template virtual-kubelet-azure-aci https://github.com/virtual-kubelet/azure-aci/raw/gh-pages/charts/virtual-kubelet-azure-aci-1.6.0.tgz
  2. Notice invalid value on line 93
    Expected behavior
    The app label would only be used once and be allowed with Flux HelmRelease controller
    Virtual-kubelet version
    1.6.0
    Kubernetes version
    n/a
    Additional context
@adamrlynch
Copy link
Author

This looks to be caused by the inclusion of the app in the label list here: https://github.com/virtual-kubelet/azure-aci/blob/817daca1417db318ae426652d0a74136d59768de/charts/virtual-kubelet/templates/_helpers.tpl#L28C1-L28C1 and then again in the deployment file here:

app: {{ template "vk.fullname" . }}
with two different template values. I'm not familiar enough with how these values are being used elsewhere but since the current setup would override a value anyway the template file should have logic to use one or the other and the separate label removed from the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant