-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unittests #4
Comments
I am happy to help with this one - see also this PR. With the current setup, the main question is, which CI infrastructure to use. Travis CI is effectively gone for open-source projects. And github actions is the current place to run your scripts. That effectively also means, that all unit tests should be light weight to run on a single CPU. |
The following issue can be closed once the new tests are done: |
Please consider merging vislearn/FrEIA#55. It will trigger continuous integration with github actions. This will be the basis for further unit tests to build. |
Thanks @tbung for merging vislearn/FrEIA#55. I'd also like your thoughts to the unittest library being used. See vislearn/FrEIA#56 |
Hmm, the action appears under the 'Actions' tab, but it's not running. Does anyone have insights? |
Should be triggered by the next PRs coming in that use the workflow code. I'll see to something like this in the afternoon. But
feel free to submit a PR and experiment.
|
What?
The test coverage is very low. There is no unified way to test e.g. invertibility, or Jacobian (has to be written once, and can work for all modules).
How?
Set up the proper structure to test all modules in a universal way, in addition to module specific tests that may be necessary. Ensure there is test coverage for everything, including
FrEIA.framework.ReversibleGraphNet
andFrEIA.framework.ReversibleSequential
.The text was updated successfully, but these errors were encountered: