Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests #4

Open
psteinb opened this issue Feb 8, 2021 · 6 comments
Open

Unittests #4

psteinb opened this issue Feb 8, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@psteinb
Copy link
Collaborator

psteinb commented Feb 8, 2021

What?

The test coverage is very low. There is no unified way to test e.g. invertibility, or Jacobian (has to be written once, and can work for all modules).

How?

Set up the proper structure to test all modules in a universal way, in addition to module specific tests that may be necessary. Ensure there is test coverage for everything, including FrEIA.framework.ReversibleGraphNet and FrEIA.framework.ReversibleSequential.

@psteinb
Copy link
Collaborator Author

psteinb commented Feb 8, 2021

I am happy to help with this one - see also this PR.

With the current setup, the main question is, which CI infrastructure to use. Travis CI is effectively gone for open-source projects. And github actions is the current place to run your scripts. That effectively also means, that all unit tests should be light weight to run on a single CPU.

@psteinb psteinb added the help wanted Extra attention is needed label Feb 8, 2021
@ardizzone
Copy link
Member

The following issue can be closed once the new tests are done:
vislearn/FrEIA#45

This was referenced Feb 9, 2021
@psteinb
Copy link
Collaborator Author

psteinb commented Feb 9, 2021

Please consider merging vislearn/FrEIA#55. It will trigger continuous integration with github actions. This will be the basis for further unit tests to build.

@psteinb
Copy link
Collaborator Author

psteinb commented Feb 10, 2021

Thanks @tbung for merging vislearn/FrEIA#55. I'd also like your thoughts to the unittest library being used. See vislearn/FrEIA#56

@ardizzone
Copy link
Member

Hmm, the action appears under the 'Actions' tab, but it's not running. Does anyone have insights?

@psteinb
Copy link
Collaborator Author

psteinb commented Feb 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants