Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal A discussion points #12

Closed
glyn opened this issue Jun 1, 2020 · 4 comments
Closed

Proposal A discussion points #12

glyn opened this issue Jun 1, 2020 · 4 comments
Assignees
Labels
comparison This issue relates to https://cburgmer.github.io/json-path-comparison/ question Further information is requested

Comments

@glyn
Copy link
Contributor

glyn commented Jun 1, 2020

Issues raised

Applying filters to objects

Raised cburgmer/json-path-comparison#41.

See:

Multiplication, division, and scripting

Raised cburgmer/json-path-comparison#42.

See these examples where an operator is not treated as part of key:

Proposal A lists multiplication and division as "to dos". Is this the thin end of the wedge for scripting?

Dot notation without root

Raised cburgmer/json-path-comparison#45.

Leading zeroes in numeric literals

Raised cburgmer/json-path-comparison#46.

Duplicates in filter results

Raised cburgmer/json-path-comparison#47.

See:

### Typo fix

Raised cburgmer/json-path-comparison#48.

Issues not raised

&& usually binds more tightly than || (and seems to be the case in JavaScript), but:

If implementors can't agree pretty unanimously that && binds more tightly than ||, then we can't expect users to expect that. So Proposal A's behaviour of failing to compile the path is a good option.

@glyn glyn added enhancement New feature or request question Further information is requested comparison This issue relates to https://cburgmer.github.io/json-path-comparison/ and removed enhancement New feature or request labels Jun 1, 2020
@glyn
Copy link
Contributor Author

glyn commented Jun 1, 2020

@cburgmer: I'd prefer to discuss the above with you before raising issues, but perhaps you'd prefer issues so that the discussion is "on the record". What do you think?

@glyn
Copy link
Contributor Author

glyn commented Jun 2, 2020

See https://github.com/cburgmer/json-path-comparison/tree/master/proposals/Proposal_A for some of the rationale of Proposal A.

@glyn glyn changed the title Issues to raise against Proposal A Proposal A discussion points Jun 2, 2020
@cburgmer
Copy link

cburgmer commented Jun 3, 2020

Yes, let's discuss.
I'd prefer to not branch out into actual implementations, but rather centralise this - quite probably over at json-path-comparison. The goal is to allow other authors to join the discussions (even if we will not capture many of the major implementations it seems).

I don't know how to structure this though. We could start with Github issues. If we find this is hard to structure, we could try moving into the wiki later.

@glyn
Copy link
Contributor Author

glyn commented Jun 8, 2020

All the issues have been raised.

@glyn glyn closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comparison This issue relates to https://cburgmer.github.io/json-path-comparison/ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants