Backup hooks command not showing in logs

[geraldibm]

When configuring backup hooks with Velero we are unsure the command runs. We don't see the command in the log output of Velero or the container/pods of the project we try to backup. Any insights on expected output in the logs or configuration are appreciated.

Some more info on what we try to achieve:
|| Can you explain what are you trying to achieve using the below command on container sh -c 'set -x; /sbin/fsfreeze --freeze /'":

We try to suspend acces to the filesystem so we can make a backup of the current state of the project from the root folder. We added the sh -c to check if there would be output in the logs then but it didn't help.

| Also was the backup successful or it got into error state ?

Yes, the backups are successful, just nothing in the logs to indicate that the command was run. Also no indication that the command failed or anything.

Our current configuration:

apiVersion: velero.io/v1
kind: Backup
metadata:
  annotations:
    velero.io/source-cluster-k8s-gitversion: v1.27.11+ec42b99
    velero.io/source-cluster-k8s-major-version: '1'
    velero.io/source-cluster-k8s-minor-version: '27'
  resourceVersion: '23762191'
  name: backup-pnst-with-command-sh
  generation: 14
  managedFields:
    - apiVersion: velero.io/v1
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:labels': {}
        'f:spec':
          .: {}
          'f:defaultVolumesToRestic': {}
          'f:hooks': {}
          'f:includedNamespaces': {}
          'f:storageLocation': {}
          'f:ttl': {}
      manager: kubectl-create
      operation: Update
      time: '2024-05-07T10:43:28Z'
    - apiVersion: velero.io/v1
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            .: {}
            'f:velero.io/source-cluster-k8s-gitversion': {}
            'f:velero.io/source-cluster-k8s-major-version': {}
            'f:velero.io/source-cluster-k8s-minor-version': {}
          'f:labels':
            'f:velero.io/storage-location': {}
        'f:spec':
          'f:csiSnapshotTimeout': {}
          'f:defaultVolumesToFsBackup': {}
          'f:itemOperationTimeout': {}
          'f:volumeSnapshotLocations': {}
        'f:status':
          'f:progress':
            .: {}
            'f:itemsBackedUp': {}
            'f:totalItems': {}
          'f:expiration': {}
          'f:version': {}
          'f:completionTimestamp': {}
          'f:phase': {}
          'f:startTimestamp': {}
          'f:warnings': {}
          'f:formatVersion': {}
          .: {}
      manager: velero-server
      operation: Update
      time: '2024-05-07T10:44:49Z'
    - apiVersion: velero.io/v1
      fieldsType: FieldsV1
      fieldsV1:
        'f:spec':
          'f:hooks':
            'f:resources': {}
      manager: Mozilla
      operation: Update
      time: '2024-05-08T11:42:09Z'
  namespace: openshift-adp
  labels:
    velero.io/storage-location: oadp-minio-1
spec:
  volumeSnapshotLocations:
    - oadp-minio-1
  defaultVolumesToRestic: true
  defaultVolumesToFsBackup: true
  csiSnapshotTimeout: 10m0s
  ttl: 720h0m0s
  itemOperationTimeout: 1h0m0s
  storageLocation: oadp-minio-1
  hooks:
    resources:
      - excludedResources: []
        includedNamespaces:
          - ibas-pnst
        includedResources:
          - pods
        labelSelector:
          matchLabels:
            app: velero
            component: server
        name: hook-try-out
        post:
          - exec:
              command:
                - "sh -c 'set -x; /sbin/fsfreeze --unfreeze /'"
              container: fsfreeze
              onError: Fail
              timeout: 30s
        pre:
          - exec:
              command:
                - "sh -c 'set -x; /sbin/fsfreeze --freeze /'"
              container: fsfreeze
              onError: Fail
              timeout: 30s
  includedNamespaces:
    - ibas-pnst

[kaovilai]

"running exec hook" will show in logs like this one if it did ran.

velero/pkg/podexec/pod_command_executor.go

Line 133 in 8752c3a

hookLog.Info("running exec hook")