Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pod volume context #8664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Feb 5, 2025

Refactor pod volume context code to avoid misuse of podVolumeTimeout which is integrated to a context with a general name ctx

@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.37%. Comparing base (294bbbc) to head (de17004).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/backup/backup.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8664      +/-   ##
==========================================
- Coverage   59.39%   59.37%   -0.02%     
==========================================
  Files         370      370              
  Lines       39987    39989       +2     
==========================================
- Hits        23750    23744       -6     
- Misses      14745    14752       +7     
- Partials     1492     1493       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review February 5, 2025 08:27
@Lyndon-Li Lyndon-Li requested a review from kaovilai February 5, 2025 08:27
pkg/backup/backup.go Outdated Show resolved Hide resolved
Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li Lyndon-Li requested a review from sseago February 6, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants