Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploying custom theme on device #758

Open
lbm-services opened this issue Jun 29, 2020 · 0 comments
Open

deploying custom theme on device #758

lbm-services opened this issue Jun 29, 2020 · 0 comments

Comments

@lbm-services
Copy link

For deployment, you suggest copying the content of dist directory on Volumio2 device to volumio/http/www.
"Classic" theme will be overwritten this way of course.
Since you are only checking Volumio3 true/false in index.js , there is no other way, I guess.

// Checking if we use Volumio3 UI
if (fs.existsSync(volumio2UIFlagFile) || !fs.existsSync(volumio3UIFolderPath)) {
  process.env.VOLUMIO_3_UI = 'false';
} else {
  process.env.VOLUMIO_3_UI = 'true';
}

But it would be nice to choose the new theme by theme selector and go back if required.
It would require to build a theme selector in the new theme as well, of course.

If a developer wants to preserve out-of-the-box themes, you have to rename theme folders back and forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant