Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate installed node version (and npm/yarn version?) against engine definition #2

Open
voxpelli opened this issue Oct 21, 2016 · 7 comments

Comments

@voxpelli
Copy link
Owner

As stated in title – currently only installed modules are checked against the required version ranges, engines are not at all verified against any installed versions.

@flippidippi
Copy link

+1 I installed this package thinking it would check my installed node/npm version. I think the current checks are useful, but adding that last check against the current installed node/npm against engines would be awesome.

@flippidippi
Copy link

Currently we are using this package along with https://github.com/kruppel/check-engines.
I think adding that logic into node-installed-check would make sense and cover all the checks.

@voxpelli
Copy link
Owner Author

I haven't forgotten about this, would like to get it in soon 🙈

@flippidippi
Copy link

Any chance this is still looking to be added?

@bcomnes
Copy link

bcomnes commented Oct 17, 2024

Maybe an easy way to do this would be to references the version npm that shipped with the lowest version of node, if that data is roughly available.

@flippidippi
Copy link

flippidippi commented Oct 18, 2024

I ended up making a new package that did everything I needed which checks installed engines and semver of node modules installed.

https://www.npmjs.com/package/check-installed

@voxpelli
Copy link
Owner Author

Right, but isn’t this more or less built into package managers nowadays?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants