Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Snippets, inline instead #743

Open
mkhraisha opened this issue Apr 18, 2023 · 4 comments
Open

Remove Snippets, inline instead #743

mkhraisha opened this issue Apr 18, 2023 · 4 comments
Assignees
@BenjaminMoe
Labels
post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr

Comments

@mkhraisha
Copy link
Collaborator

No description provided.

@nissimsan
Copy link
Collaborator

I think we should inline instead, remove snippets.

@BenjaminMoe BenjaminMoe self-assigned this Sep 26, 2023
@nissimsan
Copy link
Collaborator

@mkhraisha , pls change this to to recommend inlining

@mkhraisha
Copy link
Collaborator Author

As of today we are in-lining instead of using Snippets, we should remove Snippets and in-line instead

@mkhraisha mkhraisha changed the title Define in docs how to use Snippets Remove Snippets, inline instad Sep 26, 2023
@mkhraisha mkhraisha changed the title Remove Snippets, inline instad Remove Snippets, inline instead Sep 26, 2023
@mkhraisha mkhraisha added the post-1.0 This is for issues that are important but should not block 1.0 label Jan 30, 2024
@mkhraisha
Copy link
Collaborator Author

I believe we should make sure we are not using snippets anymore, but it should not block 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminMoe BenjaminMoe

Labels
post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkhraisha @nissimsan @BenjaminMoe