-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-inline-3] The behavior when one value is specified for text-box-edge
#10703
Comments
Defaulting to It's also more symmetrical to use text: if you specify only |
That makes sense, thank you for the background. I agree
Isn't it invalid to specify only @michaeltaranto Thank you for your feedback, please see discussion here, we appreciate your comments if any. |
Ah, no, that's my mistake. :) We could allow it, but I suppose there's no real use case. But that would allow re-ordering which might be convenient, so I'll open a separate issue. |
"Many writing systems" sounds like a bit too strong to me, when all diacritical marks of Latin scripts, CJK glyphs, and all tall scripts are beyond But I don't have strong opinions either way. @michaeltaranto are you happy with the above responses? |
Thanks for including me on this, and sorry for what seems like initial confusion in this issue. Just to clarify, I am not proposing the change the default bottom edge for all values to The point I am making in the linked comment is that when a user opts to trim to I would propose that the outcome for single value text edges be as follows: With the following updates to the value definitions in the spec:
|
@michaeltaranto For a lot of fonts, the ascent is actually much higher than the cap height. So while your chart looks very nice, it doesn't actually match reality since what you're describing as ascent+descent is actually not the set of metrics that you get with The The logic of matching it up to the |
@fantasai 100% agree (this was part of my original feedback) — I was merely trying to follow the design presented in the draft spec (Figure 5) to keep the discussion here focused. I too disagree with the conflation of the Worth noting, Figure 5 in the draft spec also has a mistake, the value in the middle example should be I would say I find these comments above to be contradictory:
which as we are saying, the ascenders and other diacritic marks certainly do extend beyond cap height in many fonts. Honestly i don't mind having to specify both edges, but i do find it a little confusing that CSS has decided to choose what terms it shares with typography and font metrics. For example, providing I would love to see: text-edge: cap baseline; It's even illustrated as But hey, thats my opinion. Happy to discuss further, and appreciate all your time on this. |
Discussing with @kojiishi, our proposal is to just require specifying both edges, unless the keyword can be duplicated. This avoids any surprises from defaulting the second keyword to something unexpected; and we can relax the rule later if we want. |
@michaeltaranto The problem with |
The CSS Working Group just discussed
The full IRC log of that discussion<matthieud> fantasai: koji got developer feedback about when only one value specific for tex-box-edge it' s confusing that it default to text edge for the unspecified<matthieud> fantasai: the reason the default is text because it's always valid, conservative value <matthieud> fantasai: the other current keyword like alphabectif trim agressively <matthieud> fantasai: we should not change the default for this reason <matthieud> fantasai: but we can require 2 keywords <kizu> +1 to requiring both <matthieud> fantasai: in any case when that keywords can' t be double (like `cap cap` is not valid) <matthieud> florian: the original design makes sense but not gonna object to change <Rossen16> q? <matthieud> PROPOSAL: 2 values are required unless the single value provided can be doubled <florian> 0 <matthieud> RESOLVED: 2 values are required unless the single value provided can be doubled |
This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712
This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625}
This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625}
This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625}
…o require two values, a=testonly Automatic update from web-platform-tests [text-box-trim] Change `text-box-edge` to require two values This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625} -- wpt-commits: 152ce7bb8a35f2556fbdee5a6021edab69709ba5 wpt-pr: 49156
…o require two values, a=testonly Automatic update from web-platform-tests [text-box-trim] Change `text-box-edge` to require two values This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625} -- wpt-commits: 152ce7bb8a35f2556fbdee5a6021edab69709ba5 wpt-pr: 49156
…o require two values, a=testonly Automatic update from web-platform-tests [text-box-trim] Change `text-box-edge` to require two values This patch changes the `text-box-edge` property to require two values if the `over` and the `under` are different, as per the resolution at the CSS WG[1]: [1]: w3c/csswg-drafts#10703 Bug: 373867786, 40254880 Change-Id: I385bf5fa1fdb45cd6990f1a079878f5a683d8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017004 Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382625} -- wpt-commits: 152ce7bb8a35f2556fbdee5a6021edab69709ba5 wpt-pr: 49156
I believe this resolution was a mistake, so I opened a new issue asking to revert it. |
There was a web developer feedback to the Blink's experimental implementation for when one value is specified.
The current spec says:
The feedback says, if only one value is specified, to assume the
alphabetic
under edge instead oftext
if the over edge iscap
orex
, to make it more intuitive.Does this look like a reasonable change? @fantasai @Clqsin45 @nt1m @argyleink @chrishtr @bfgeek
The text was updated successfully, but these errors were encountered: