Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the fullscreen pre-lock condition also check for fullscreen state of parent document? #255

Open
EdgarChen opened this issue Jan 10, 2025 · 1 comment

Comments

@EdgarChen
Copy link

EdgarChen commented Jan 10, 2025

Similar to #254. Another unclear point is in the unlock() aborts a pending lock request across documents test in unlock.html. The test expects the lock to be allowed when the parent document is in fullscreen. I am not sure if this is a test bug, or an intentional behavior.

If this is intentional behavior, it would be good if we could define this more clearly in the spec. And perhaps we should only allow it when the parent document is same-origin; otherwise, the fullscreen state could be leaked to the cross-origin iframe? Also we would also need to define how to handle the lock when the parent document exits fullscreen.

@EdgarChen
Copy link
Author

Oh, there are also some tests for such behavior in https://github.com/web-platform-tests/wpt/blob/master/screen-orientation/nested-documents.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant