Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update game generation for specific games & Pokedexes #175

Open
wavebeem opened this issue Dec 2, 2022 · 2 comments
Open

Update game generation for specific games & Pokedexes #175

wavebeem opened this issue Dec 2, 2022 · 2 comments
Labels
enhancement An enhancement to an existing feature

Comments

@wavebeem
Copy link
Owner

wavebeem commented Dec 2, 2022

Using the regional Pokedex pages, I could scrape the lists and added some new fields for Pokemon to make an array of games they've been in

https://pokemondb.net/pokedex

Note

This would be a breaking change for people who have selected a non-default game generation, since I would want to break out gen 2-5 into a list of specific pokemon games

In doing this I should have some validation for the old values that could come thru in localStorage

@wavebeem wavebeem added the enhancement An enhancement to an existing feature label Dec 2, 2022
@corsair
Copy link

corsair commented Oct 7, 2023

Hi! I'm just commenting that including which games a pokemon appears in would be such an incredible addition and be meaningful for working on a living dex (among other focuses).

Long-time fan of your service, and thank you for everything you do!

@wavebeem
Copy link
Owner Author

wavebeem commented Oct 7, 2023

Thank you @corsair!

I'm a bit conflicted here because I generally prefer sourcing data from PokeAPI due to it being a JSON API and having Pokemon names in multiple languages...

but yeah, PokemonDB has such a broader scope of data...

What do you mean working on a living dex?

Full transparency, I don't actually play Pokemon that much lately, so I don't tend to work on a ton of issues for this project, as you can tell by checking out the issues page haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants