New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger is always enabled #207

Open

roidelapluie opened this issue Dec 9, 2020 · 1 comment

roidelapluie commented Dec 9, 2020

common/tracing/tracing.go

Line 38 in 47e357f

    
           if cfg.Sampler.SamplingServerURL == "" && cfg.Reporter.LocalAgentHostPort == "" && cfg.Reporter.CollectorEndpoint == "" {

Jaeger is always enabled because LocalAgentHostPort is by default ('localhost:6831').

Annoyingly the env variables used by jaeger are not publicly exposed by the jaeger package so a quick&clean fix is not that easy.

Author

roidelapluie commented Dec 9, 2020

https://github.com/jaegertracing/jaeger-client-go/blob/17fd3e8e517a4630dc276675cb2987782094a022/config/config_env.go#L201-L207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment