Remove and ignore go workspace files #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
approved these changes
Nov 6, 2023
There's no watertight advice on whether to check go workspace files in (go.work and go.work.sum), but generally they are regarded as local. See golang/go#53502 as the most central discussion on this). Here, they tend to get in the way, because `go.work.sum` is not updated by `go mod tidy` and isn't subject to (the default) `-mod readonly`. In the absence of a clear benefit to checking them in, I'm removing them. Signed-off-by: Michael Bridgen <[email protected]>
squaremo
force-pushed
the
ignore-workspace-files
branch
from
f0fb2bd to
b01f388
Compare
|
Thank you for reviewing this Max 🙇 I meant to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no watertight advice on whether to check go workspace files in (go.work and go.work.sum), but generally they are regarded as local. See golang/go#53502 as the most central discussion on this).
Here, they tend to get in the way, because
go.work.sumis not updated bygo mod tidyand isn't subject to (the default)-mod readonly. In the absence of a clear benefit to checking them in, I'm removing them.