From 9628df982f718fae98e470c5683c0f89e859ed17 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Wed, 12 Jun 2024 14:34:52 +0200 Subject: [PATCH 01/12] fix(plugin-meetings): numberOfCores stats --- packages/@webex/plugin-meetings/package.json | 1 + .../plugin-meetings/src/mediaQualityMetrics/config.ts | 3 +++ .../@webex/plugin-meetings/src/statsAnalyzer/index.ts | 5 ++--- .../test/unit/spec/stats-analyzer/index.js | 9 +++++++++ 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/packages/@webex/plugin-meetings/package.json b/packages/@webex/plugin-meetings/package.json index ca2123fd36b..da0663df82e 100644 --- a/packages/@webex/plugin-meetings/package.json +++ b/packages/@webex/plugin-meetings/package.json @@ -74,6 +74,7 @@ "@webex/media-helpers": "workspace:*", "@webex/plugin-people": "workspace:*", "@webex/plugin-rooms": "workspace:*", + "@webex/web-capabilities": "1.3.0", "@webex/webex-core": "workspace:*", "ampersand-collection": "^2.0.2", "bowser": "^2.11.0", diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index 28492d1c3d1..105d6abdfba 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -4,6 +4,9 @@ export const emptyMqaInterval = { intervalMetadata: { peerReflexiveIP: '0.0.0.0', peripherals: [], + cpuInfo: { + numberOfCores: 0, + }, processAverageCPU: 0, processMaximumCPU: 0, systemAverageCPU: 0, diff --git a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts index 46a25721a40..f146e125b6e 100644 --- a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts +++ b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts @@ -1,8 +1,6 @@ -/* eslint-disable prefer-destructuring */ - import {cloneDeep, isEmpty} from 'lodash'; +import {CpuInfo} from '@webex/web-capabilities'; import {ConnectionState} from '@webex/internal-media-core'; - import EventsScope from '../common/events/events-scope'; import { DEFAULT_GET_STATS_FILTER, @@ -398,6 +396,7 @@ export class StatsAnalyzer extends EventsScope { }); newMqa.intervalMetadata.peerReflexiveIP = this.statsResults.connectionType.local.ipAddress; + newMqa.intervalMetadata.cpuInfo.numberOfCores = CpuInfo.getNumLogicalCores(); // Adding peripheral information newMqa.intervalMetadata.peripherals.push({information: _UNKNOWN_, name: MEDIA_DEVICES.SPEAKER}); diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index e2998bd780f..1b2bf5fe550 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -10,6 +10,7 @@ import testUtils from '../../../utils/testUtils'; import {MEDIA_DEVICES, MQA_INTERVAL, _UNKNOWN_} from '@webex/plugin-meetings/src/constants'; import LoggerProxy from '../../../../src/common/logs/logger-proxy'; import LoggerConfig from '../../../../src/common/logs/logger-config'; +import {CpuInfo} from '@webex/web-capabilities'; const {assert} = chai; @@ -2113,6 +2114,14 @@ describe('plugin-meetings', () => { } }); }); + + it('has correct cpu info about number of cores', async () => { + sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12); + await startStatsAnalyzer({expected: {receiveVideo: true}}); + + await progressTime(); + assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, 12); + }) }); }); }); From 2061b5b1214af4406ae44ce3419658e4d7f0535e Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Thu, 20 Jun 2024 15:03:29 +0200 Subject: [PATCH 02/12] fix(plugin-meetings): update init values for cpuInfo --- .../@webex/plugin-meetings/src/mediaQualityMetrics/config.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index 105d6abdfba..715f828f15f 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -5,7 +5,9 @@ export const emptyMqaInterval = { peerReflexiveIP: '0.0.0.0', peripherals: [], cpuInfo: { - numberOfCores: 0, + numberOfCores: 1, + description: 'web client', + architecture: 'unknown', }, processAverageCPU: 0, processMaximumCPU: 0, From 12a93c6a748ffc214908852dcd3f118bf3e47ba9 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Thu, 11 Jul 2024 14:10:51 +0200 Subject: [PATCH 03/12] refactor(plugin-meetings): refactor tests --- .../test/unit/spec/stats-analyzer/index.js | 2 +- yarn.lock | 19 ++++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index 1b2bf5fe550..8791871d0fe 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2115,7 +2115,7 @@ describe('plugin-meetings', () => { }); }); - it('has correct cpu info about number of cores', async () => { + it('reports the number of logical CPU cores', async () => { sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12); await startStatsAnalyzer({expected: {receiveVideo: true}}); diff --git a/yarn.lock b/yarn.lock index 5e1d02f7bba..2f9f1177f8d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8157,6 +8157,7 @@ __metadata: "@webex/test-helper-mock-webex": "workspace:*" "@webex/test-helper-retry": "workspace:*" "@webex/test-helper-test-users": "workspace:*" + "@webex/web-capabilities": 1.3.0 "@webex/webex-core": "workspace:*" ampersand-collection: ^2.0.2 bowser: ^2.11.0 @@ -8831,6 +8832,15 @@ __metadata: languageName: unknown linkType: soft +"@webex/web-capabilities@npm:1.3.0, @webex/web-capabilities@npm:^1.3.0": + version: 1.3.0 + resolution: "@webex/web-capabilities@npm:1.3.0" + dependencies: + bowser: ^2.11.0 + checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812 + languageName: node + linkType: hard + "@webex/web-capabilities@npm:^1.1.0": version: 1.2.0 resolution: "@webex/web-capabilities@npm:1.2.0" @@ -8840,15 +8850,6 @@ __metadata: languageName: node linkType: hard -"@webex/web-capabilities@npm:^1.3.0": - version: 1.3.0 - resolution: "@webex/web-capabilities@npm:1.3.0" - dependencies: - bowser: ^2.11.0 - checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812 - languageName: node - linkType: hard - "@webex/web-client-media-engine@npm:3.20.4": version: 3.20.4 resolution: "@webex/web-client-media-engine@npm:3.20.4" From c03417ed045d7700a7507ecae620cc3a8822d49b Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 10:48:56 +0200 Subject: [PATCH 04/12] refactor(plugin-meetings): refactor code add undefined for numLogicalCores --- .../src/mediaQualityMetrics/config.ts | 2 +- .../src/statsAnalyzer/index.ts | 6 +++++- yarn.lock | 20 +++++++++---------- 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index 715f828f15f..24d1298860c 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -5,7 +5,7 @@ export const emptyMqaInterval = { peerReflexiveIP: '0.0.0.0', peripherals: [], cpuInfo: { - numberOfCores: 1, + numberOfCores: undefined, description: 'web client', architecture: 'unknown', }, diff --git a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts index f146e125b6e..abd3ab442f7 100644 --- a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts +++ b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts @@ -396,7 +396,11 @@ export class StatsAnalyzer extends EventsScope { }); newMqa.intervalMetadata.peerReflexiveIP = this.statsResults.connectionType.local.ipAddress; - newMqa.intervalMetadata.cpuInfo.numberOfCores = CpuInfo.getNumLogicalCores(); + + const numLogicalCores = CpuInfo.getNumLogicalCores(); + if (numLogicalCores) { + newMqa.intervalMetadata.cpuInfo.numberOfCores = numLogicalCores; + } // Adding peripheral information newMqa.intervalMetadata.peripherals.push({information: _UNKNOWN_, name: MEDIA_DEVICES.SPEAKER}); diff --git a/yarn.lock b/yarn.lock index 2f9f1177f8d..fc7880c79ea 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8157,7 +8157,7 @@ __metadata: "@webex/test-helper-mock-webex": "workspace:*" "@webex/test-helper-retry": "workspace:*" "@webex/test-helper-test-users": "workspace:*" - "@webex/web-capabilities": 1.3.0 + "@webex/web-capabilities": ^1.3.0 "@webex/webex-core": "workspace:*" ampersand-collection: ^2.0.2 bowser: ^2.11.0 @@ -8832,15 +8832,6 @@ __metadata: languageName: unknown linkType: soft -"@webex/web-capabilities@npm:1.3.0, @webex/web-capabilities@npm:^1.3.0": - version: 1.3.0 - resolution: "@webex/web-capabilities@npm:1.3.0" - dependencies: - bowser: ^2.11.0 - checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812 - languageName: node - linkType: hard - "@webex/web-capabilities@npm:^1.1.0": version: 1.2.0 resolution: "@webex/web-capabilities@npm:1.2.0" @@ -8850,6 +8841,15 @@ __metadata: languageName: node linkType: hard +"@webex/web-capabilities@npm:^1.3.0": + version: 1.3.0 + resolution: "@webex/web-capabilities@npm:1.3.0" + dependencies: + bowser: ^2.11.0 + checksum: 5e35c7d17cfd21762f86e16e2237d6e6c3a7b157e38f3a694ffa8e9003ada423fb85e2eca502dd7cf09560896e33007bbb244d87b04d4344152ab2049b60f812 + languageName: node + linkType: hard + "@webex/web-client-media-engine@npm:3.20.4": version: 3.20.4 resolution: "@webex/web-client-media-engine@npm:3.20.4" From ed71e84b9fcb54accd16b677d651f06223b73161 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 10:49:44 +0200 Subject: [PATCH 05/12] refactor(plugin-meetings): update package.json --- packages/@webex/plugin-meetings/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@webex/plugin-meetings/package.json b/packages/@webex/plugin-meetings/package.json index da0663df82e..99c55770752 100644 --- a/packages/@webex/plugin-meetings/package.json +++ b/packages/@webex/plugin-meetings/package.json @@ -74,7 +74,7 @@ "@webex/media-helpers": "workspace:*", "@webex/plugin-people": "workspace:*", "@webex/plugin-rooms": "workspace:*", - "@webex/web-capabilities": "1.3.0", + "@webex/web-capabilities": "^1.3.0", "@webex/webex-core": "workspace:*", "ampersand-collection": "^2.0.2", "bowser": "^2.11.0", From 285bdb37cf656562de726af9654b2f70fe5acfce Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 11:23:47 +0200 Subject: [PATCH 06/12] refactor(plugin-meetings): update tests --- .../test/unit/spec/stats-analyzer/index.js | 38 +++++++++++++++---- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index 8791871d0fe..72cc01aaf4a 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2115,13 +2115,37 @@ describe('plugin-meetings', () => { }); }); - it('reports the number of logical CPU cores', async () => { - sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12); - await startStatsAnalyzer({expected: {receiveVideo: true}}); + describe.only('CPU Information Reporting', async () => { + let getNumLogicalCoresStub; - await progressTime(); - assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, 12); - }) - }); + beforeEach(async () => { + // Ensure any previous stub is restored before creating a new one + if (getNumLogicalCoresStub) { + getNumLogicalCoresStub.restore(); + } + getNumLogicalCoresStub = sinon.stub(CpuInfo, 'getNumLogicalCores'); + }); + + afterEach(() => { + // Restore the stub to its original method after each test + getNumLogicalCoresStub.restore(); + }); + + it('reports undefined of logical CPU cores when not available', async () => { + getNumLogicalCoresStub.returns(undefined); + await startStatsAnalyzer({expected: {receiveVideo: true}}); + await progressTime(); + assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, undefined); + }); + + it('reports the number of logical CPU cores', async () => { + sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12); + await startStatsAnalyzer({expected: {receiveVideo: true}}); + + await progressTime(); + assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, 12); + }); + }); + }) }); }); From 4c5436a5318f4779780ebb29b833cc101003430b Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 11:26:18 +0200 Subject: [PATCH 07/12] refactor(plugin-meetings): update tests --- .../plugin-meetings/test/unit/spec/stats-analyzer/index.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index 72cc01aaf4a..b843fc9ae23 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2119,7 +2119,6 @@ describe('plugin-meetings', () => { let getNumLogicalCoresStub; beforeEach(async () => { - // Ensure any previous stub is restored before creating a new one if (getNumLogicalCoresStub) { getNumLogicalCoresStub.restore(); } @@ -2127,7 +2126,6 @@ describe('plugin-meetings', () => { }); afterEach(() => { - // Restore the stub to its original method after each test getNumLogicalCoresStub.restore(); }); From 4e8571d60c5944ead80af1da4f43ab219e4412eb Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 12:10:48 +0200 Subject: [PATCH 08/12] refactor(plugin-meetings): refactor tests --- .../plugin-meetings/test/unit/spec/stats-analyzer/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index b843fc9ae23..35d93b604d2 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2115,7 +2115,7 @@ describe('plugin-meetings', () => { }); }); - describe.only('CPU Information Reporting', async () => { + describe('CPU Information Reporting', async () => { let getNumLogicalCoresStub; beforeEach(async () => { From 516056271e79402991b4ba37474353c70dd37563 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Fri, 12 Jul 2024 12:10:48 +0200 Subject: [PATCH 09/12] refactor(plugin-meetings): refactor tests and code --- .../plugin-meetings/src/mediaQualityMetrics/config.ts | 2 +- .../test/unit/spec/stats-analyzer/index.js | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index 24d1298860c..9bbf42b9061 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -5,7 +5,7 @@ export const emptyMqaInterval = { peerReflexiveIP: '0.0.0.0', peripherals: [], cpuInfo: { - numberOfCores: undefined, + numberOfCores: 1, // default value from spec if web-caability cannot be determined description: 'web client', architecture: 'unknown', }, diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index 35d93b604d2..d4a47521829 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2129,16 +2129,17 @@ describe('plugin-meetings', () => { getNumLogicalCoresStub.restore(); }); - it('reports undefined of logical CPU cores when not available', async () => { + it('reports 1 of logical CPU cores when not available', async () => { getNumLogicalCoresStub.returns(undefined); - await startStatsAnalyzer({expected: {receiveVideo: true}}); + await startStatsAnalyzer({pc, statsAnalyzer, mediaStatus: {expected: {receiveVideo: true}}}); + await progressTime(); - assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, undefined); + assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, 1); }); it('reports the number of logical CPU cores', async () => { - sinon.stub(CpuInfo, 'getNumLogicalCores').returns(12); - await startStatsAnalyzer({expected: {receiveVideo: true}}); + getNumLogicalCoresStub.returns(12); + await startStatsAnalyzer({pc, statsAnalyzer, mediaStatus: {expected: {receiveVideo: true}}}); await progressTime(); assert.equal(mqeData.intervalMetadata.cpuInfo.numberOfCores, 12); From 439bb86e79cf09f0fbc534d8c8983e2643180f70 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Mon, 15 Jul 2024 18:08:56 +0200 Subject: [PATCH 10/12] refactor(plugin-meetings): refactor comments --- .../@webex/plugin-meetings/src/mediaQualityMetrics/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index 9bbf42b9061..dd71ddda2c1 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -5,7 +5,7 @@ export const emptyMqaInterval = { peerReflexiveIP: '0.0.0.0', peripherals: [], cpuInfo: { - numberOfCores: 1, // default value from spec if web-caability cannot be determined + numberOfCores: 1, // default value from spec if CpuInfo.getNumLogicalCores cannot be determined description: 'web client', architecture: 'unknown', }, From 49747ed4ac40d8d1d67597e8294c87d6934437dd Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Tue, 16 Jul 2024 08:54:34 +0200 Subject: [PATCH 11/12] refactor(plugin-meetings): refactor code with numberOfCores --- packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts index abd3ab442f7..a3464b325ea 100644 --- a/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts +++ b/packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts @@ -397,10 +397,7 @@ export class StatsAnalyzer extends EventsScope { newMqa.intervalMetadata.peerReflexiveIP = this.statsResults.connectionType.local.ipAddress; - const numLogicalCores = CpuInfo.getNumLogicalCores(); - if (numLogicalCores) { - newMqa.intervalMetadata.cpuInfo.numberOfCores = numLogicalCores; - } + newMqa.intervalMetadata.cpuInfo.numberOfCores = CpuInfo.getNumLogicalCores() || 1; // Adding peripheral information newMqa.intervalMetadata.peripherals.push({information: _UNKNOWN_, name: MEDIA_DEVICES.SPEAKER}); From 343f687c8bf89deec00dd969e7b5bc35f521aa28 Mon Sep 17 00:00:00 2001 From: Anna Tsukanova Date: Wed, 17 Jul 2024 11:34:50 +0200 Subject: [PATCH 12/12] refactor(plugin-meetings): refactor tests and description value --- .../@webex/plugin-meetings/src/mediaQualityMetrics/config.ts | 2 +- .../plugin-meetings/test/unit/spec/stats-analyzer/index.js | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts index dd71ddda2c1..1958f080cc9 100644 --- a/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts +++ b/packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts @@ -6,7 +6,7 @@ export const emptyMqaInterval = { peripherals: [], cpuInfo: { numberOfCores: 1, // default value from spec if CpuInfo.getNumLogicalCores cannot be determined - description: 'web client', + description: 'NA', architecture: 'unknown', }, processAverageCPU: 0, diff --git a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js index d4a47521829..10e95492170 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js @@ -2119,9 +2119,6 @@ describe('plugin-meetings', () => { let getNumLogicalCoresStub; beforeEach(async () => { - if (getNumLogicalCoresStub) { - getNumLogicalCoresStub.restore(); - } getNumLogicalCoresStub = sinon.stub(CpuInfo, 'getNumLogicalCores'); });