-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official Dockerfiles #101
Comments
Note that |
Maybe something was lost in the translation, but this just states that the specific workflow (mount+modify) is a bad practice (which I agree with). For running the container on an orchestration platform, there is no good alternative as templating outside the container environment is not always an (easy) option, it can make sense to bake the config into the image, but inject certain variables (basic auth credentials, ACLs, etc) at runtime. |
@mschfh Thank you, so the use case actually looks like a workaround for the orchestration solution limitation. |
Hi @mschfh Can you have a look and/or try to build and play with the resulting image? |
The need to add the In addition, the option of changing the config on the fly at the time of container launch will not work if a read-only file system is used Still, I would like Angie to automatically detect the presence of restrictions in Cgroup and launch workers in accordance with this restriction |
Please note that this particular issue (#101) is about template support in a broader sense but not only proper cpu constraints. This implies support for conditional blocks and loops (features that are obviously impossible with simple scalar substitutions). |
Regarding template support - is it possible to embed a simple template engine (or maybe a complex one) into Angie that will allow values from environment variables to be substituted into a template without resorting to third-party tools or shell scripts? |
What kind of engine or syntax do you suggest? |
If we are talking about adding a full-fledged template engine, then Go Tempaltes is widely used in cloud/containers environments, it is literally everywhere and will look organic Jinja2 is also not bad, there is an implementation in C++ For the topic discussed within the framework of this issue, a simple replacement in the line will probably be sufficient. |
Please provide the official Dockerfiles used for building the docker images to allow Pull requests/contributions (such as
envsubst
for feature parity with thenginx
images).The text was updated successfully, but these errors were encountered: