Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace fromId by talkerId, toId by listenerId #26

Merged
merged 16 commits into from
Apr 8, 2022
Merged

replace fromId by talkerId, toId by listenerId #26

merged 16 commits into from
Apr 8, 2022

Conversation

fabian4
Copy link
Member

@fabian4 fabian4 commented Apr 8, 2022

@fabian4 fabian4 requested review from su-chang and huan April 8, 2022 07:38
huan
huan approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Good job!

huan
huan approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Good job!

@huan
Copy link
Member

huan commented Apr 8, 2022

BTW: We should also bump the version of the walnut to v1.18 so that it can be sync with the Wechaty Puppet version.

@fabian4 fabian4 merged commit 210d871 into wechaty:main Apr 8, 2022
@fabian4 fabian4 deleted the fix_talkerId_and_listenerId branch April 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@su-chang su-chang su-chang approved these changes

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace fromId by talkerId, toId by listenerId
3 participants
@fabian4 @huan @su-chang