Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect imperatives with prefixes #22

Open
1 of 3 tasks
welpo opened this issue Apr 18, 2024 · 3 comments
Open
1 of 3 tasks

Detect imperatives with prefixes #22

welpo opened this issue Apr 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@welpo
Copy link
Owner

welpo commented Apr 18, 2024

Feature Request

Summary

git-sumi should detect imperatives with prefixes. For example, "write" is in the list of non-imperative verbs (as "written", "wrote"), but "rewrite" is not.

Motivation

It would improve non-imperative-verb detection.

Detailed Description

The logic to detect imperative verbs should not only match the first word against the hashset, but check whether it matches a list of prefixes + a word in the list.

As an initial list of prefixes, we could consider:

  • re (reuse, reindex)
  • un (undelete, unskip)
  • pre (prebuilt, preinitialize)

Additional Context

It's probably a good idea to check for:

  • Base verb (this is implemented)
  • Prefix + dash + verb
  • Prefix + verb
@welpo welpo added the enhancement New feature or request label Apr 18, 2024
@welpo
Copy link
Owner Author

welpo commented Apr 18, 2024

@bcignasi would you like to work on this?

@bcignasi
Copy link

Yeah. I'll get to it this week!

@welpo
Copy link
Owner Author

welpo commented Sep 9, 2024

Some of these prefixes could be relevant: https://trieve.ai/building-blazingly-fast-typo-correction-in-rust/#2-affix-analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants