Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: fix numbered code blocks #437

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

welpo
Copy link
Owner

@welpo welpo commented Nov 23, 2024

Summary

Adds padding for line numbers in code blocks. Reduces their opacity (made it similar to VSCode), and standardises the font size between all code blocks (those with line numbers had a larger font).

Adds numbered code block to Markdown demo.

Related issue

Fixes #435 (#434)

Screenshots

Before, no spacing, larger font when adding line numbers:

big

After:

small

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit dd53ba2
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/6741f8c83c99520008ca67bd
😎 Deploy Preview https://deploy-preview-437--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 123110e into main Nov 23, 2024
8 checks passed
@welpo welpo deleted the style/fix-numbered-code-blocks branch November 23, 2024 15:49
@welpo
Copy link
Owner Author

welpo commented Nov 24, 2024

Related: 4be8a56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codeblocks: Padding between line number and code
1 participant