Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning from live host check #1286

Open
Zarquan opened this issue Feb 13, 2024 · 0 comments
Open

Remove warning from live host check #1286

Zarquan opened this issue Feb 13, 2024 · 0 comments
Assignees
Labels
low priority Things we can do when we have time

Comments

@Zarquan
Copy link
Collaborator

Zarquan commented Feb 13, 2024

Our deployment script starts with a sanity check to make sure we aren't deleting the live system. However, that same check always outputs a scary looking warning that suggests we are accessing the live system.

Warning: Permanently added 'live.gaia-dmp.uk' (ED25519) to the list of known hosts.

This warning is produced because we are running the live host check in a clean container and this is the first time that it has accessed the live system, so it has to add the ssh host fingerprint to the known_hosts file.

Best way to avoid this is to check for the host fingerprint and add it if it is missing before we make the ssh call.

This might not be critical, but seeing this warning at the start of every new deployment makes us inured to warnings which is dangerous. We also have to explain it to every new person who joins the team. Their first impression of the project is sloppy attitude to warnings.

@Zarquan Zarquan added the low priority Things we can do when we have time label Feb 13, 2024
@Zarquan Zarquan self-assigned this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Things we can do when we have time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant