Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you going to merge the CocoaPods branch? #8

Open
fjtrujy opened this issue Aug 5, 2019 · 2 comments
Open

Are you going to merge the CocoaPods branch? #8

fjtrujy opened this issue Aug 5, 2019 · 2 comments

Comments

@fjtrujy
Copy link

fjtrujy commented Aug 5, 2019

Hello,
Currently, the master branch (version 2.1.2) is returning a warning when the CRuntime is used through Cocoapods.

It basically complains about the modulemap file is under the sources.

Screenshot 2019-08-05 at 18 55 27

I was going to do a fork, fix it myself and create a PR, but I already saw that you fixed here https://github.com/wickwirew/CRuntime/tree/cocoapods
Do you have plans to merge it? How Can I help?

Thanks!

@wickwirew
Copy link
Owner

That branch has other issues. The Runtime project will complain it cannot find CRuntime. If you know how to fix it I’d be more than happy to merge it!

@fjtrujy
Copy link
Author

fjtrujy commented Aug 8, 2019

I have created a PR. #9
Give a try and let me if everything is ok.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants