Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming of columns between ERIO and Base functions #331

Open
atmorling opened this issue Nov 20, 2024 · 0 comments
Open

Inconsistent naming of columns between ERIO and Base functions #331

atmorling opened this issue Nov 20, 2024 · 0 comments

Comments

@atmorling
Copy link
Contributor

As you can see in the spec change it looks like I'm referring to two different columns,
in working through the fix for this I had to trace through the workflow to figure out what happens to the column name:

get_subjectgroup_observations returns with extra__subject__name
process_relocations turns extra__subject__name into name
relocations_to_trajectory re-adds extra so from name to extra__name

To me this highlights the need for a rethink of our column naming in ecoscope core and something to look at with a refactor of the base Relocs and Traj objects, if not sooner...

Originally posted by @atmorling in https://github.com/wildlife-dynamics/ecoscope-workflows/issues/425#issuecomment-2474464825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant