Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete file from S3 fails because of missing normalization #31

Open
eitanshapiro opened this issue Jan 21, 2020 · 3 comments
Open

Delete file from S3 fails because of missing normalization #31

eitanshapiro opened this issue Jan 21, 2020 · 3 comments

Comments

@eitanshapiro
Copy link

Thumbor report successful delete while in practice the delete fails.

@eitanshapiro
Copy link
Author

Adding this code to s3_storage.py solves the issue

@return_future
def remove(self, path, callback=None):
    """
    Deletes data at path
    :param string path: Path to delete
    """
    super(Storage, self).remove(self._normalize_path(path), callback)

================================================

@eitanshapiro
Copy link
Author

Failed to push new branch:
remote: Permission to thumbor-community/aws.git denied to eitanshapiro.

@eitanshapiro
Copy link
Author

Trying to push new branch with fix and I don't have permission
git push origin fix_delete_file_missing_normalization_path
remote: Permission to thumbor-community/aws.git denied to eitanshapiro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant