Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.xsd does not pass validation by itself #340

Open
mgoberfield opened this issue Dec 17, 2024 · 3 comments
Open

common.xsd does not pass validation by itself #340

mgoberfield opened this issue Dec 17, 2024 · 3 comments

Comments

@mgoberfield
Copy link
Contributor

mgoberfield commented Dec 17, 2024

Complex types defined in common.xsd make use of types defined in measure.xsd but the file is not included.

  1. Attempt to perform schema validation on common.xsd
  2. Types "iwxxm:LengthWithNilReasonType" and "iwxxm:DistanceWithNilReasonType" are undefined
  3. These missing types are defined in "measure.xsd"

Schema files are expected to pass schema validation.

Adding an <include schemaLocation="measures.xsd"/> directive near the top of common.xsd file resolves the errors.
If implemented, this makes the include directives of "measure.xsd" and "common.xsd" in iwxxm.xsd unnecessary as individual product schemas all include common.xsd again. This may be due to EA production. However, repeated calls to include schemas do not seem to have harmful effects.

@amilan17
Copy link
Member

@blchoy

@blchoy
Copy link
Member

blchoy commented Jan 22, 2025

Adding an directive near the top of common.xsd file resolves the errors.
If implemented, this makes the include directives of "measure.xsd" and "common.xsd" in iwxxm.xsd unnecessary as individual product schemas all include common.xsd again. This may be due to EA production. However, repeated calls to include schemas do not seem to have harmful effects.

True and agreed with the suggested changes.

A more drastic change is to incorporate them into common.xsd, just like StringWithNilReasonType. @mgoberfield any views on this?

@amilan17
Copy link
Member

amilan17 commented Jan 22, 2025

https://github.com/wmo-im/iwxxm/wiki/TT-AvData-Discussion-2025-Jan-22 notes:

  • the team discussed the option of removing measures.xsd instead
  • team decided to import measures into common.xsd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants