New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent insert function argument naming #12

Open

EvgSkv opened this issue Feb 15, 2022 · 0 comments

EvgSkv commented Feb 15, 2022

We have two signatures for insert function and the second array is named inconsistently. Is it on purpose? If not, should we rename it?

any-sketch-java/src/main/java/org/wfanet/anysketch/AnySketch.java

Line 116 in c8ab0f3

public void insert(String item, Map<String, Long> itemMetadata) {

any-sketch-java/src/main/java/org/wfanet/anysketch/AnySketch.java

Line 132 in c8ab0f3

public void insert(Long item, Map<String, Long> values) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment