Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abuse the_title filter so badly. #2361

Open
jbeales opened this issue Feb 5, 2018 · 0 comments
Open

Don't abuse the_title filter so badly. #2361

jbeales opened this issue Feb 5, 2018 · 0 comments

Comments

@jbeales
Copy link
Member

jbeales commented Feb 5, 2018

Looking at my logs, I'm seeing a lot of warnings about a filter I added to the_title, many of which come from WPeC.

According to the the_title docs, the filter takes exactly 2 arguments: The string to be filtered, and the post ID.

There are plenty of places in WPeC where we're passing just a single argument, (for example, wpsc-components/theme-engine-v1/widgets/latest_product_widget.php, line 150).

In Line 362 of wpsc-includes/cart-item.class.php we're even passing an instance of the WPSC_Cart_Item class as the second argument, instead of an ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant