From cefc69bf571f5ff97acb95b4258a1eb4318f2653 Mon Sep 17 00:00:00 2001 From: AmshikaH Date: Mon, 13 Jan 2025 12:22:31 +0530 Subject: [PATCH 1/4] Update SAML connection ProviderName config name --- .changeset/small-radios-help.md | 6 ++++++ .../saml-authenticator-form.tsx | 20 +++++++++---------- .../namespaces/authentication-provider-ns.ts | 2 +- .../en-US/portals/authentication-provider.ts | 2 +- 4 files changed, 18 insertions(+), 12 deletions(-) create mode 100644 .changeset/small-radios-help.md diff --git a/.changeset/small-radios-help.md b/.changeset/small-radios-help.md new file mode 100644 index 00000000000..a3bead0dc87 --- /dev/null +++ b/.changeset/small-radios-help.md @@ -0,0 +1,6 @@ +--- +"@wso2is/admin.connections.v1": major +"@wso2is/i18n": major +--- + +Update SAML connection ProviderName config name diff --git a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx index 29d8954782c..749e2f01861 100644 --- a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx +++ b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx @@ -116,7 +116,7 @@ export interface SamlPropertiesInterface { IncludeCert?: boolean; IncludeNameIDPolicy?:boolean; AuthnContextClassRef?: string; - AuthnReqProviderName?: string; + samlAuthnRequestProviderName?: string; } const FORM_ID: string = "saml-authenticator-form"; @@ -250,7 +250,7 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent({ defaultValue: authorizedRedirectURL, key: "AuthRedirectUrl" }), AuthnContextClassRef: findPropVal({ defaultValue: "", key: "AuthnContextClassRef" }), AuthnContextComparisonLevel: findPropVal({ defaultValue: "", key: "AuthnContextComparisonLevel" }), - AuthnReqProviderName: findPropVal({ defaultValue: "", key: "AuthnReqProviderName" }), + samlAuthnRequestProviderName: findPropVal({ defaultValue: "", key: "samlAuthnRequestProviderName" }), CustomAuthnContextClassRef: findPropVal({ defaultValue: "", key: "CustomAuthnContextClassRef" }), DigestAlgorithm: findPropVal({ defaultValue: "SHA256", key: "DigestAlgorithm" }), ForceAuthentication: findPropVal({ defaultValue: "string", key: "ForceAuthentication" }), @@ -964,20 +964,20 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent - { t(`${ I18N_TARGET_KEY }.authnReqProviderName.label`) } + + { t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.label`) } ) } maxLength={ IDENTITY_PROVIDER_AUTHENTICATION_REQUEST_PROVIDER_NAME_LENGTH.max } minLength={ IDENTITY_PROVIDER_AUTHENTICATION_REQUEST_PROVIDER_NAME_LENGTH.min } - hint={ t(`${ I18N_TARGET_KEY }.authnReqProviderName.hint`) } + hint={ t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.hint`) } readOnly={ readOnly } /> diff --git a/modules/i18n/src/models/namespaces/authentication-provider-ns.ts b/modules/i18n/src/models/namespaces/authentication-provider-ns.ts index b6cad78ee02..24a17c73635 100644 --- a/modules/i18n/src/models/namespaces/authentication-provider-ns.ts +++ b/modules/i18n/src/models/namespaces/authentication-provider-ns.ts @@ -812,7 +812,7 @@ export interface AuthenticationProviderNS { placeholder: string; ariaLabel: string; }; - authnReqProviderName: { + samlAuthnRequestProviderName: { hint: string; label: string; placeholder: string; diff --git a/modules/i18n/src/translations/en-US/portals/authentication-provider.ts b/modules/i18n/src/translations/en-US/portals/authentication-provider.ts index 504f6b27abe..897487b666e 100644 --- a/modules/i18n/src/translations/en-US/portals/authentication-provider.ts +++ b/modules/i18n/src/translations/en-US/portals/authentication-provider.ts @@ -801,7 +801,7 @@ export const authenticationProvider:AuthenticationProviderNS = { hint: "Specify if SAMLAssertion element is encrypted", label: "Enable assertion encryption" }, - authnReqProviderName: { + samlAuthnRequestProviderName: { hint: "The human-readable name of the requester.", label: "Authentication Request Provider Name", placeholder: "Enter authentication request provider name", From ac4589a8808ee586027c708f276358b1ca143ac1 Mon Sep 17 00:00:00 2001 From: AmshikaH Date: Mon, 13 Jan 2025 13:03:29 +0530 Subject: [PATCH 2/4] Fix eslint issues --- .../edit/forms/authenticators/saml-authenticator-form.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx index 749e2f01861..353ab34f6d1 100644 --- a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx +++ b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx @@ -250,7 +250,6 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent({ defaultValue: authorizedRedirectURL, key: "AuthRedirectUrl" }), AuthnContextClassRef: findPropVal({ defaultValue: "", key: "AuthnContextClassRef" }), AuthnContextComparisonLevel: findPropVal({ defaultValue: "", key: "AuthnContextComparisonLevel" }), - samlAuthnRequestProviderName: findPropVal({ defaultValue: "", key: "samlAuthnRequestProviderName" }), CustomAuthnContextClassRef: findPropVal({ defaultValue: "", key: "CustomAuthnContextClassRef" }), DigestAlgorithm: findPropVal({ defaultValue: "SHA256", key: "DigestAlgorithm" }), ForceAuthentication: findPropVal({ defaultValue: "string", key: "ForceAuthentication" }), @@ -293,6 +292,8 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent({ defaultValue: "", + key: "samlAuthnRequestProviderName" }), SPEntityId: findPropVal({ defaultValue: "", key: "SPEntityId" }), SSOUrl: findPropVal({ defaultValue: "", key: "SSOUrl" }), SignatureAlgorithm: findPropVal({ defaultValue: "RSA with SHA256", key: "SignatureAlgorithm" }), From 8a9fbe3a42efb3fd650804ea403396dedebb72c4 Mon Sep 17 00:00:00 2001 From: AmshikaH Date: Mon, 13 Jan 2025 14:37:48 +0530 Subject: [PATCH 3/4] Change order of keys --- .../forms/authenticators/saml-authenticator-form.tsx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx index 353ab34f6d1..bae0e14873b 100644 --- a/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx +++ b/features/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx @@ -292,8 +292,6 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent({ defaultValue: "", - key: "samlAuthnRequestProviderName" }), SPEntityId: findPropVal({ defaultValue: "", key: "SPEntityId" }), SSOUrl: findPropVal({ defaultValue: "", key: "SSOUrl" }), SignatureAlgorithm: findPropVal({ defaultValue: "RSA with SHA256", key: "SignatureAlgorithm" }), @@ -301,8 +299,11 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent({ defaultValue: false, key: "isAssertionSigned" }) - + isAssertionSigned: findPropVal({ defaultValue: false, key: "isAssertionSigned" }), + samlAuthnRequestProviderName: findPropVal({ + defaultValue: "", + key: "samlAuthnRequestProviderName" + }) } as SamlPropertiesInterface; }, []); From 9ecf97c14319c2af32a0ef375c02c4b70cf159d5 Mon Sep 17 00:00:00 2001 From: AmshikaH Date: Fri, 17 Jan 2025 16:10:43 +0530 Subject: [PATCH 4/4] =?UTF-8?q?Add=20changeset=20=F0=9F=A6=8B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .changeset/five-chefs-smile.md | 6 ++++++ .changeset/small-radios-help.md | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 .changeset/five-chefs-smile.md delete mode 100644 .changeset/small-radios-help.md diff --git a/.changeset/five-chefs-smile.md b/.changeset/five-chefs-smile.md new file mode 100644 index 00000000000..1619c1364c2 --- /dev/null +++ b/.changeset/five-chefs-smile.md @@ -0,0 +1,6 @@ +--- +"@wso2is/admin.connections.v1": minor +"@wso2is/i18n": minor +--- + +Update SAML connection ProviderName config name diff --git a/.changeset/small-radios-help.md b/.changeset/small-radios-help.md deleted file mode 100644 index a3bead0dc87..00000000000 --- a/.changeset/small-radios-help.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -"@wso2is/admin.connections.v1": major -"@wso2is/i18n": major ---- - -Update SAML connection ProviderName config name