Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated functionality for Ruby 2.7 #206

Open
panbanda opened this issue Jul 13, 2021 · 7 comments
Open

Deprecated functionality for Ruby 2.7 #206

panbanda opened this issue Jul 13, 2021 · 7 comments

Comments

@panbanda
Copy link

Hey there.

/app/vendor/cache/ruby/2.7.0/bundler/gems/scoped_search-b692e7335357/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/app/vendor/cache/ruby/2.7.0/bundler/gems/scoped_search-b692e7335357/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

Seeing this error a lot with the separation of positional and keyword arguments.

https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

I am using the v4.1.9 branch.

@adamruzicka
Copy link
Collaborator

This should most likely be fixed by #204 , could you check with latest master?

@panbanda
Copy link
Author

Yep, seems to be fixed. @adamruzicka

BTW, saw that there are some tags being made but no releases. Is there a reason for that?

@adamruzicka
Copy link
Collaborator

I'm not sure I follow. The tags are in the repo and corresponding releases are out on rubygems. Or are you talking about some other release?

@panbanda
Copy link
Author

Sorry, spoke too soon. My logs just spat out the same error for master at rev 92939af

@panbanda panbanda reopened this Jul 13, 2021
@panbanda
Copy link
Author

I'm not sure I follow. The tags are in the repo and corresponding releases are out on rubygems. Or are you talking about some other release?

Ah, yes I was looking at the gh releases. Thought it was all tied together.

@panbanda
Copy link
Author

panbanda commented Aug 11, 2021

Just FYI, seeing the latest with 4.1.9

/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

@slayer
Copy link

slayer commented Oct 4, 2021

also got

/usr/local/bundle/ruby/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/usr/local/bundle/ruby/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants