Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backfill-batch-delay and backfill-batch-size flags to the start command #657

Open
andrew-farries opened this issue Feb 5, 2025 · 0 comments · May be fixed by #660
Open

Move backfill-batch-delay and backfill-batch-size flags to the start command #657

andrew-farries opened this issue Feb 5, 2025 · 0 comments · May be fixed by #660
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@andrew-farries
Copy link
Collaborator

Currently, the --backfill-batch-delay and --backfill-batch-size flags are global flags:

Usage:
  pgroll [command]

Available Commands:
  complete    Complete an ongoing migration with the operations present in the given file
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  init        Initialize pgroll in the target database
  latest      Print the name of the latest schema version, either in the target database or a local directory
  migrate     Apply outstanding migrations from a directory to a database
  pull        Pull migration history from the target database and write it to disk
  rollback    Roll back an ongoing migration
  start       Start a migration for the operations present in the given file
  status      Show pgroll status

Flags:
      --backfill-batch-delay duration   Duration of delay between batch backfills (eg. 1s, 1000ms)
      --backfill-batch-size int         Number of rows backfilled in each batch (default 1000)
  -h, --help                            help for pgroll
      --lock-timeout int                Postgres lock timeout in milliseconds for pgroll DDL operations (default 500)
      --pgroll-schema string            Postgres schema to use for pgroll internal state (default "pgroll")
      --postgres-url string             Postgres URL (default "postgres://postgres:postgres@localhost?sslmode=disable")
      --role string                     Optional postgres role to set when executing migrations
      --schema string                   Postgres schema to use for the migration (default "public")
  -v, --version                         version for pgroll

Use "pgroll [command] --help" for more information about a command.

but they only make sense when applied to the start command.

The two flags should be removed from global flags and added as start command flags.

@andrew-farries andrew-farries added the good first issue Good for newcomers label Feb 5, 2025
@andrew-farries andrew-farries added this to the v1 milestone Feb 5, 2025
@kvch kvch self-assigned this Feb 6, 2025
@kvch kvch linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants