You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
I'm working on some changes to the Scala Money library and I was looking at being able to propagate additional state about the span context across the Money headers. As the header is already a delimited set of name/value pairs it seemed like it would be fine to add additional values into the existing header:
However I noticed that the Go implementation of money assumes that there can only be 3 key value pairs otherwise it fails to parse the header.
I was curious as to how much impact there could be in making this change to the X-MoneyTrace header (specifically how many Go services might be impacted due to requests coming from JVM-based services), and whether it might be possible to implement this change.
I'm working on some changes to the Scala Money library and I was looking at being able to propagate additional state about the span context across the Money headers. As the header is already a delimited set of name/value pairs it seemed like it would be fine to add additional values into the existing header:
However I noticed that the Go implementation of money assumes that there can only be 3 key value pairs otherwise it fails to parse the header.
I was curious as to how much impact there could be in making this change to the
X-MoneyTrace
header (specifically how many Go services might be impacted due to requests coming from JVM-based services), and whether it might be possible to implement this change.I've submitted a PR to implement this change: #44
@ptravers
The text was updated successfully, but these errors were encountered: