Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS AN administrator I NEED TO grant and remove super-user privileges to other users SO THAT they can also access the administration panel #7

Open
1 of 3 tasks
arrested-developer opened this issue Sep 11, 2019 · 3 comments
Assignees
Labels
3-points Issue size estimation priority-2

Comments

@arrested-developer
Copy link
Contributor

arrested-developer commented Sep 11, 2019

  • I can grant super-user privileges
  • I can view a list of all users with super-user privileges
  • I can revoke super-user privileges
dupreesi pushed a commit that referenced this issue Sep 11, 2019
dupreesi pushed a commit that referenced this issue Sep 11, 2019
@arrested-developer arrested-developer added 3-points Issue size estimation priority-3 labels Sep 19, 2019
@arrested-developer arrested-developer changed the title AS AN administrator I NEED TO grant and remove admin or super-user privileges to other users SO THAT they can also access the administration panel AS AN administrator I NEED TO grant and remove super-user privileges to other users SO THAT they can also access the administration panel Sep 20, 2019
@dupreesi dupreesi self-assigned this Sep 26, 2019
@dupreesi
Copy link
Collaborator

dupreesi commented Sep 26, 2019

@arrested-developer a few questions:

  • can the admin user grant super user privileges to all verified users or only to those awaiting SuperUser status?
  • I assume that users awaiting super user privileges are verified users and that they will stay verified user if rejected.... so if a user gets rejected super user status then the model would be updated like
role: user,
status: verified

does it make sense to create a status that indicates that a user has previously been rejected super user privileges?
likes

status: rejectedSuperUserStatus

or

rejectedSuperUserStatusBy: AdminId

@arrested-developer
Copy link
Contributor Author

arrested-developer commented Sep 26, 2019

can the admin user grant super user privileges to all verified users or only to those awaiting SuperUser status?

Let's keep it to those who've requested super user status - that way it works more or less the same for admin and super users and we're not creating two different flows

does it make sense to create a status that indicates that a user has previously been rejected super user privileges?

For now, no, let's keep this really simple. If the request for super user is rejected then they go back to verified. I think if we were to improve this system later, perhaps we might need a requests collection so we can track what happens

@dupreesi
Copy link
Collaborator

tasks

  • setup query to deal with approve and reject functions updating user model accordingly
  • setup handler to process request, query and response
  • setup usePatch custom hook
  • send request from REACT component
  • handle response in REACT component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-points Issue size estimation priority-2
Projects
None yet
Development

No branches or pull requests

2 participants