From 701136ecd0cbc82b82490f51a6d5cd67b5e7549d Mon Sep 17 00:00:00 2001
From: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Date: Tue, 17 Dec 2024 22:59:21 +0900
Subject: [PATCH] fix: Rocm types

---
 fft/src/KokkosFFT_ROCM_transform.hpp | 12 ++++++------
 fft/src/KokkosFFT_ROCM_types.hpp     |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/fft/src/KokkosFFT_ROCM_transform.hpp b/fft/src/KokkosFFT_ROCM_transform.hpp
index 86b783b6..e4d45abd 100644
--- a/fft/src/KokkosFFT_ROCM_transform.hpp
+++ b/fft/src/KokkosFFT_ROCM_transform.hpp
@@ -12,7 +12,7 @@
 namespace KokkosFFT {
 namespace Impl {
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, float* idata,
+void exec_plan(ScopedPlanType& scoped_plan, float* idata,
                std::complex<float>* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
@@ -22,7 +22,7 @@ void exec_plan(const ScopedPlanType& scoped_plan, float* idata,
 }
 
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, double* idata,
+void exec_plan(ScopedPlanType& scoped_plan, double* idata,
                std::complex<double>* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
@@ -32,7 +32,7 @@ void exec_plan(const ScopedPlanType& scoped_plan, double* idata,
 }
 
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, std::complex<float>* idata,
+void exec_plan(ScopedPlanType& scoped_plan, std::complex<float>* idata,
                float* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
@@ -42,7 +42,7 @@ void exec_plan(const ScopedPlanType& scoped_plan, std::complex<float>* idata,
 }
 
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, std::complex<double>* idata,
+void exec_plan(ScopedPlanType& scoped_plan, std::complex<double>* idata,
                double* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
@@ -52,7 +52,7 @@ void exec_plan(const ScopedPlanType& scoped_plan, std::complex<double>* idata,
 }
 
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, std::complex<float>* idata,
+void exec_plan(ScopedPlanType& scoped_plan, std::complex<float>* idata,
                std::complex<float>* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
@@ -62,7 +62,7 @@ void exec_plan(const ScopedPlanType& scoped_plan, std::complex<float>* idata,
 }
 
 template <typename ScopedPlanType>
-void exec_plan(const ScopedPlanType& scoped_plan, std::complex<double>* idata,
+void exec_plan(ScopedPlanType& scoped_plan, std::complex<double>* idata,
                std::complex<double>* odata, int /*direction*/) {
   rocfft_status status =
       rocfft_execute(scoped_plan.plan(), (void**)&idata, (void**)&odata,
diff --git a/fft/src/KokkosFFT_ROCM_types.hpp b/fft/src/KokkosFFT_ROCM_types.hpp
index 4774408c..80e23531 100644
--- a/fft/src/KokkosFFT_ROCM_types.hpp
+++ b/fft/src/KokkosFFT_ROCM_types.hpp
@@ -203,11 +203,11 @@ struct ScopedRocfftPlan {
 
   // Helper to convert the integer type of vectors
   template <typename InType, typename OutType>
-  auto convert_int_type_and_reverse(std::vector<InType> &in)
+  auto convert_int_type_and_reverse(const std::vector<InType> &in)
       -> std::vector<OutType> {
     std::vector<OutType> out(in.size());
     std::transform(
-        in.begin(), in.end(), out.begin(),
+        in.cbegin(), in.cend(), out.begin(),
         [](const InType v) -> OutType { return static_cast<OutType>(v); });
 
     std::reverse(out.begin(), out.end());