Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

inCaseStrategyGetStruck #4

Open
francoabaroa opened this issue Aug 31, 2020 · 2 comments
Open

inCaseStrategyGetStruck #4

francoabaroa opened this issue Aug 31, 2020 · 2 comments

Comments

@francoabaroa
Copy link

francoabaroa commented Aug 31, 2020 •
edited
Loading

StrategyControllerV2.sol function name (inCaseStrategyGetStruck) - should it be inCaseStrategyGetStuck?

https://github.com/iearn-finance/vaults/blob/211f85b87f7a52c44c93e5e9a227372aef71c070/contracts/StrategyControllerV2.sol#L100

Just wanted to highlight this in case it was a crucial misspelling error

PS. Huge fan of AC & Yearn
@francoabaroa francoabaroa changed the title https://github.com/iearn-finance/vaults/blob/master/contracts/StrategyControllerV2.sol#L100 inCaseStrategyGetStruck vs. inCaseStrategyTokenGetStuck Aug 31, 2020
@francoabaroa francoabaroa changed the title inCaseStrategyGetStruck vs. inCaseStrategyTokenGetStuck inCaseStrategyGetStruck Aug 31, 2020
@arberx
Copy link

arberx commented Sep 2, 2020

I would propose a PR and replace every instance.

@senpagax
Copy link

senpagax commented Sep 6, 2020 •
edited
Loading

#7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arberx @francoabaroa @senpagax