Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC and versionVector handling in documents created after v0.5.6 #1081

Open
hackerwins opened this issue Nov 26, 2024 · 0 comments
Open

GC and versionVector handling in documents created after v0.5.6 #1081

hackerwins opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
bug 🐞 Something isn't working

Comments

@hackerwins
Copy link
Member

hackerwins commented Nov 26, 2024

What happened:

Starting from v0.5.6, there was a change where the browser is now able to deactivate the client during the beforeunload in CodePair, leading to GC being processed.

However, when testing documents created after v0.5.6, the following issues were observed:

  • Executing doc.getGarbageLen() on documents created after v0.5.6 appears to correctly remove garbage under normal conditions.
  • However, there are discrepancies in the sizes of doc.changeID.versionVector and doc.presences. Occasionally, versionVector does not decrease, while presences appear to be cleaned up correctly.

image

What you expected to happen:

The expectation is that GC should function correctly for both documents created after v0.5.6, ensuring that both doc.presences and versionVector maintain corresponding sizes.

How to reproduce it (as minimally and precisely as possible):

https://codepair.yorkie.dev/hackerwins/674522059b55661e04668721/share?token=c5uq0y

Anything else we need to know?:

Related to #723

Environment:

  • Operating system: All
  • Browser and version: All
  • Yorkie version (use yorkie version): v0.5.6
  • Yorkie JS SDK version: v0.5.6
@hackerwins hackerwins added the bug 🐞 Something isn't working label Nov 26, 2024
@hackerwins hackerwins moved this from Backlog to In progress in Yorkie Project - 2024 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

2 participants