Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing limits #158

Open
hackerwins opened this issue Mar 7, 2021 · 2 comments
Open

Introducing limits #158

hackerwins opened this issue Mar 7, 2021 · 2 comments
Labels
enhancement 🌟 New feature or request hard 🧑‍🔬 Difficult to deal with or require research

Comments

@hackerwins
Copy link
Member

hackerwins commented Mar 7, 2021 •
edited
Loading

What would you like to be added:

Yorkie has no limits yet. It would be nice to add limits as below.

Key Name Description
max-document-bytes Maximum document size Yorkie saves snapshots for quick document rebuilds. If the snapshot of the document gets bigger, it may exceed the limit of DB. The size of one field must not exceed the maximum size of a document.

Why is this needed:

The service can be stably provided with restrictions that match the characteristics.
@hackerwins hackerwins added the enhancement 🌟 New feature or request label Mar 7, 2021
@hackerwins hackerwins moved this to Todo in v0.2 Oct 29, 2021
@hackerwins hackerwins added this to v0.2 Oct 29, 2021
@hackerwins
Copy link
Member Author

related with #267

@hackerwins hackerwins removed this from v0.2 Dec 14, 2021
@hackerwins hackerwins added this to v0.3 Dec 14, 2021
@hackerwins hackerwins moved this to Todo in v0.3 Dec 14, 2021
@hackerwins hackerwins added the hard 🧑‍🔬 Difficult to deal with or require research label Jun 2, 2022
@hackerwins hackerwins removed this from v0.3 Jun 6, 2023
@hackerwins hackerwins moved this to Backlog in Yorkie Project - 2024 Aug 20, 2024
@kokodak
Copy link
Member

kokodak commented Aug 20, 2024

I'm interested in working on this issue, but I think we need to have a policy discussion about saving snapshots.

There was an assignee on issue #267, and I'm wondering if there is any background on what they were working on before.

If there is any background or planned direction for this issue, could you share some context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🌟 New feature or request hard 🧑‍🔬 Difficult to deal with or require research
Projects
Yorkie Project - 2024
Status: Backlog
Yorkie Project
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackerwins @kokodak