Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search as-you-type #114

Open
Haroenv opened this issue Nov 28, 2017 · 2 comments
Open

search as-you-type #114

Haroenv opened this issue Nov 28, 2017 · 2 comments

Comments

@Haroenv
Copy link

Haroenv commented Nov 28, 2017

right now you need to press enter before a search is executed. A nicer experience is search while you are typing, and thus listening to the input event.

I can open the PR if there's interest

@Haroenv
Copy link
Author

Haroenv commented Nov 28, 2017

Something even cooler is to have some fuzzy search too

@maxkueng
Copy link
Collaborator

maxkueng commented Nov 28, 2017

Great idea. We currently use a module called electron-in-page-search that does the searching. Maybe it can be configured to do search-as-you-type. There's also a related issue #108 which is currently quite annoying. (fixed)

I think it should behave similar to how search behaves in a web browser. Fuzzy search doesn't really make sense for searching inside a document.

If you're familiar with JavaScript or Electron you are more than welcome to give it a go. I can also try to help you if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants