Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to ids doesn't work when using letters from foreign languages like Ż #116

Open
stpoa opened this issue Dec 9, 2017 · 1 comment

Comments

@stpoa
Copy link

stpoa commented Dec 9, 2017

Below doesn't work in vmd.

  • Click url
[Header with Ż link](#header-with-ż)
# Header with Ż

Without foreign characters works as expected:

[Header with Z link](#header-with-z)
# Header with Z
@maxkueng
Copy link
Collaborator

maxkueng commented Jun 2, 2018

Interesting find. This work on GitHub if you use the same casing ([Header with Ż link](#header-with-Ż) instead of [Header with Ż link](#header-with-ż)).
However, this doesn't make it work in vmd.

The reason seems to be that the library that converts the MDAST to HTML escapes the character in the URL.

MDAST Node:
image

HTML:
image

This probably needs to be fixed in one of the remark or rehype libaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants