Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] path->rows is set incorrectly in yb_cost_bitmap_table_scan #25710

Open
1 task done
timothy-e opened this issue Jan 21, 2025 · 0 comments
Open
1 task done

[YSQL] path->rows is set incorrectly in yb_cost_bitmap_table_scan #25710

timothy-e opened this issue Jan 21, 2025 · 0 comments
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@timothy-e
Copy link
Contributor

timothy-e commented Jan 21, 2025

Jira Link: DB-14968

Description

the value of path->rows is set here then overwritten immediately after. So, the final path->rows wouldn't reflect any local filter.

furthermore, parameterized predicates are not taken into account even if it wasn't overwritten there. it's best not to recompute it once the value is set at the beginning of the function as shown below:

	/* Mark the path with the correct row estimate */
	if (param_info)
		path->rows = param_info->ppi_rows;
	else
		path->rows = baserel->rows;

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@timothy-e timothy-e added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jan 21, 2025
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants