Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal rintone picker #537

Open
yuriykulikov opened this issue Mar 20, 2023 · 0 comments
Open

Internal rintone picker #537

yuriykulikov opened this issue Mar 20, 2023 · 0 comments
Assignees
Labels

Comments

@yuriykulikov
Copy link
Owner

yuriykulikov commented Mar 20, 2023

Internal rintone picker

Summary

We need an internal ringtone picker because more phones come without ringtone picker intent receivers and default settings.

Motivation

Lack of any fallback measure causes the app to crash.

Description

Implement a simple picker activity. In addition to the usual behavior we need a button to pick with an intent. Implementation with Jetpack Compose and a ViewModel.

Take a looks at https://github.com/DeweyReed/UltimateRingtonePicker and https://android.googlesource.com/platform/packages/apps/DeskClock/+/refs/heads/master/src/com/android/deskclock/ringtone/RingtonePickerActivity.kt

Drawbacks, risks and assumptions

We can mess something up or create a picker which people don't like.
Mitigation:

  • Use only as fallback
  • Allow to use system picker
  • Switchable in settings

Rationale and alternatives

Alternatively send to user the Play market. But this won't work on F-Droid and is horrible user experience.

@yuriykulikov yuriykulikov self-assigned this Mar 20, 2023
@yuriykulikov yuriykulikov moved this to High prio in New Stuff Coming up Mar 20, 2023
@yuriykulikov yuriykulikov moved this from High prio to Todo in New Stuff Coming up Mar 20, 2023
@yuriykulikov yuriykulikov moved this from Todo to High prio in New Stuff Coming up Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: High prio
Development

No branches or pull requests

1 participant