Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

word-spacing doesn't get adjusted properly in Safari #69

Open
j0hj0h opened this issue Apr 25, 2015 · 1 comment
Open

word-spacing doesn't get adjusted properly in Safari #69

j0hj0h opened this issue Apr 25, 2015 · 1 comment

Comments

@j0hj0h
Copy link

j0hj0h commented Apr 25, 2015

I get fine results for all browsers except Safari (mobile and desktop). I know it doesn't have subpixel font-scaling, but the adjustement via word-spacing could be much more accurate. Mostly it's left untouched. I see many cases of inaccurate adjusted lines, where manual word-spacing leads to much better results.
@j0hj0h j0hj0h changed the title word-spacing doesn't get modified in Safari word-spacing doesn't get adjusted properly in Safari Apr 25, 2015
@j0hj0h
Copy link
Author

j0hj0h commented Apr 25, 2015

I fixed it. I'll create a pull request later.

j0hj0h pushed a commit to j0hj0h/BigText that referenced this issue Apr 25, 2015
Fix word-spacing adjustment (zachleat#69)
97aa8f3 
Two improvements:

- Line 267: iteration is now going up to 20px. Before it was only 3px
  which wasn't enough in some cases. In my tests it took never more then
  5px to exceed the maxWidth. So 20px should be fine (also for long
  words)

- Line 147, 163: For browsers with no support for subpixel font scaling,
  it seems to be necessary to round the values, because they might get
  rounded incorrectly. At least my Safari (6.1.6) took 0.9px for 0px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j0hj0h