From cb8a3087a9c7b82b8b14e8a9879727d9f70f7e6a Mon Sep 17 00:00:00 2001 From: Niklas Neugebauer Date: Fri, 17 Jan 2025 14:54:12 +0100 Subject: [PATCH] warn when using parameter getter and setter --- rosys/vision/rtsp_camera/rtsp_camera.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/rosys/vision/rtsp_camera/rtsp_camera.py b/rosys/vision/rtsp_camera/rtsp_camera.py index c09e299e..ee55b8af 100644 --- a/rosys/vision/rtsp_camera/rtsp_camera.py +++ b/rosys/vision/rtsp_camera/rtsp_camera.py @@ -1,4 +1,5 @@ import logging +import warnings from typing import Any from typing_extensions import Self @@ -38,7 +39,7 @@ def __init__(self, self.ip: str | None = ip self.substream = jovision_profile or substream - self._register_parameter('jovision_profile', self.get_substream, self.set_substream, + self._register_parameter('jovision_profile', self.get_jovision_profile, self.set_jovision_profile, min_value=0, max_value=1, step=1, default_value=substream) self._register_parameter('substream', self.get_substream, self.set_substream, min_value=0, max_value=1, step=1, default_value=substream) @@ -125,6 +126,18 @@ async def get_fps(self) -> int | None: return await self.device.get_fps() + def get_jovision_profile(self) -> int | None: + assert self.device is not None + warnings.warn('get_jovision_profile is deprecated, use get_substream instead', stacklevel=3) + + return self.device.get_substream() + + def set_jovision_profile(self, profile: int) -> None: + assert self.device is not None + warnings.warn('set_jovision_profile is deprecated, use set_substream instead', stacklevel=3) + + self.device.set_substream(profile) + def set_substream(self, index: int) -> None: assert self.device is not None