Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace f64 ZEC values in JSON-RPC output with a fixed-point decimal type #15

Open
str4d opened this issue Jan 30, 2025 · 0 comments
Open

Comments

@str4d
Copy link
Collaborator

str4d commented Jan 30, 2025

There are a bunch of zcashd JSON-RPC methods that return decimal ZEC values. Currently to return those with jsonrpsee and its serde interface, we use an f64, but that is fragile.

In zcashd we instead used an explicit fixed-point decimal string representation that was then encoded as a number. I'm not quite sure how to replicate this via serde, but we need to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant