Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text rendering seems too thick #12835

Open
1 task done
didier opened this issue Jun 10, 2024 · 5 comments
Open
1 task done

Text rendering seems too thick #12835

didier opened this issue Jun 10, 2024 · 5 comments
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc font Font feedback for readability, size, style, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@didier
Copy link

didier commented Jun 10, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

CleanShot 2024-06-10 at 10 35 33@2x

Font: Berkeley Mono Variable
Font Weight: 400

Compare VS Code (left) to Zed (right).
Irregardless of my font, the rendering of text strokes in Zed seems thicker throughout. This makes Zed look less crispy on high-end displays and harder to read on low-end displays.

Environment

Zed: v0.138.6 (Zed)
OS: macOS 14.5.0
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@didier didier added admin read bug [core label] labels Jun 10, 2024
@Moshyfawn Moshyfawn added workspace Feedback for workspace management, layout, interactions, etc editor Feedback for code editing, formatting, editor iterations, etc font Font feedback for readability, size, style, etc and removed triage labels Jun 10, 2024
@Moshyfawn
Copy link
Member

This seems to echo what was said in #7992. I'm going to close this: be sure to +👍 and follow the other thread. However, if you think it's unrelated, let us know so we can reopen it.

Duplicate of:

@Moshyfawn Moshyfawn closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
@didier
Copy link
Author

didier commented Jun 10, 2024

@Moshyfawn Hmm, not sure I agree—on my high DPI MBP the text still doesn't look correct. But I suppose it's worse on low DPI.

@SlowBrainDude
Copy link

SlowBrainDude commented Jul 12, 2024

I see the same issue. (On Linux, under X11, with quite current system, running Debian Testing).

It's more or less the opposite of #7992: My (TrueType) font (DejaVu) looks pixelated (and fat), not blurry.

zed-text-rendering

Compared to proper rendering:

native-text-rendering

This could be broken hinting, or some issues with antialiasing.

And that's not the only issue with font-rending in zed. What one can also see here is the broken kerning.

In the screenshot the thread opener provided < flows into / in the script tag. In my example the letter combinations "re" and "es" have clearly issues. The zed rendering is more "compressed" and uneven.

And the very next issue is missing sub-pixel rendering…

(Not sure I should open separate tickets about all that, as there are already many font rendering related ones; maybe they should get merged instead as it's more or less the same overall issue?)

To be honest: In case you're trying to do your own font-rendering, just stop that, and use FreeType. FreeType went through decades of fine tuning. You will never reach anything even close in quality. Proper font-rending is a life task. Concentrate on a good editor instead, as what I see looks quite promising! 🎉 (I just hope there shows up somewhere some build that removes all that annoying AI and online services nonsense. Such things should be plugins! Maybe even you could provide such "light" builds... 😉)

Nevertheless, thanks for building Zed! Looking forward to move away form VSC as AI, Azure, and GitHub enshittification gets stronger there with every release (and that are more or less the only areas anything moves at all by now; invocation stopped in VSC quite some time ago frankly).

@Cynosphere
Copy link

Cynosphere commented Jan 15, 2025

Chiming into this as a Windows user, as DirectWrite is abhorrently bad on some fonts (specifically agave, which is currently my preferred monospace font).

FreeType would be the way to go, but to not annoy the VSCode font purists it would have to be an option, which would just be more overhead on development of having to work on three font systems at once.

Comparison between FreeType via WezTerm (left) and DirectWrite via Zed (right):
Comparison between FreeType via WezTerm (left) and DirectWrite via Zed (right)

EDIT: I should probably also mention that the font weight option has zero effect here as well

@sammcj
Copy link

sammcj commented Jan 23, 2025

I went to log exactly this issue on macOS as well, it looks like the font 'weight' is rendering higher than it should be and that the fonts appear slightly blurry compared to other applications.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc font Font feedback for readability, size, style, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

7 participants