High CPU / power consumption with Groovy language server + others (MacOS Intel FPS) #16729
Comments
|
Since a couple of days ago, I'm having similar issues. Edit: adding system information |
|
I'm having similar issues too, I disabled language servers and still the consumption remained high. I rolled back to 0.148.0 which doesn't seem to have the issue. System info: |
|
@SchiavoAnto Yes you might be right, that it affects more languages than I thought in the beginning. I started to notice the same issues with Go. |
amaridev
changed the title
|
Same here with rust. With the latest releases, my Macbook went in full overdrive, even with the lid closed, three times so far, completely draining the battery in the process. I have to quit zed now before closing the lid. It is not the zed process creating the load though, always processes like kernel_task and Quick Look Satellite. But only if zed is running.
|
|
@mdelete Oh yeah the overheating with the lid closed happened to me too. I was using Zed and closed the laptop, like I always do, and found it very very hot and the battery was almost completely flat. |
|
Since Zed 0.149 my MacBook was getting hot, even with no LS running. I tried to leave Zed open with just a small txt file and all my personal settings removed and it's draining the battery in no time. Activity Monitor shows relatively high CPU + GPU usage. I went back to Zed 0.148 and this issue disappeared. So, there must be a serious regression between 0.148 and 0.149. |
notpeter
added
performance
|
There was quite a bit that happened between v0.148.x and v0.149.x (277 commits) as it was leading up the Zed.ai launch. Similarly a lot that has happened in the intervening time [between v0.149.x and v0.151.x] (200 commits). Are folks still seeing this issue with current releases (Zed Preview v0.151.x)? If yes, would anyone experiencing this be willing to do the git bisect from a working build to v0.149.x to help track down the offending commit? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Just tried 0.151.1, the Mac ran hot within 30 minutes. I left Zed running with an empty window. No other apps were running except Activity Monitor. Activity Monitor is confusing: Zed 0.148: Zed 0.151 There's almost no difference! I don't even know how to measure the power drain. If I didn't trust you I'd say you're running a hidden process to train your next AI model 😉 😂. I'm happy to investigate as long as I don't need to build Zed (and install all the tools to do that). |
|
@notpeter I can build from source and give that a try but like @piechologist said I have no idea how to measure for the bad commit apart from feeling my Mac and listening to the fans running. I also don't see any differences between versions in Activity Monitor. Any other ideas would be appreciated! |
|
Hi, just to make basic triage:
|
|
Browsing through this issue and adding my machine:
I tried installing via homebrew (brew uses the intel binary) and by downloading the intel binary from zed.dev. |
|
I have the similar issue using js/ts
|
|
@notpeter it took longer than I thought but this was my experience with different commits on my Mac |
|
I'd like to identify if there is a common pattern of hardware impacted by this. If you are experiencing this, please run the following and paste with a comment below and I'll collate the results and hide the comments.
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This reverts the FPS counter added in 1175391 (#16422) because in this issue someone bisected recent performance regressions down to this commit: - #16729 Another issue that's possibly related: - #17305 (comment) We're reverthing this in a PR to create a bundle that people can try out. Co-authored-by: Bennet <[email protected]>
|
Thanks @d-shah8. @bennetbo and I created a build (in https://github.com/zed-industries/zed/actions/runs/10735702994?pr=17485) for you all to try out:
In that build, the FPS counter code has been reverted (we couldn't spot an obvious reason for why it would decrease performance). Can you try out the Intel build and see if it fixes the problem? |
|
@mrnugget I am trying the Intel build and it looks like the issue is fixed |
|
@mrnugget yep issue seems fixed with that Intel build for me too. |
|
Ahhh... silence of the fans. Seems to fixed for me too (Intel build). |
|
Intel build looks good for me too. Thanks a lot! |
|
x86/Intel build looks very well. I wrote in a pull request comments at first, sorry. |
**UPDATE**: Response so far seems to be that this fixes the performance issues on Intel MacBooks. So we're going to go ahead and merge it. This reverts the FPS counter added in 1175391 (#16422) because in this issue someone bisected recent performance regressions down to this commit: - #16729 Another issue that's possibly related: - #17305 (comment) We're reverting this in a PR to create a bundle that people can try out. Assets: - Universal Binary: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460781 - x86/Intel: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900461236 - Apple Silicon: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460978 Release Notes: - Removed the recently-added FPS counter since the changes it made to the Metal renderer on macOS could lead to performance regressions on Intel MacBooks. Co-authored-by: Bennet <[email protected]>
**UPDATE**: Response so far seems to be that this fixes the performance issues on Intel MacBooks. So we're going to go ahead and merge it. This reverts the FPS counter added in 1175391 (#16422) because in this issue someone bisected recent performance regressions down to this commit: - #16729 Another issue that's possibly related: - #17305 (comment) We're reverting this in a PR to create a bundle that people can try out. Assets: - Universal Binary: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460781 - x86/Intel: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900461236 - Apple Silicon: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460978 Release Notes: - Removed the recently-added FPS counter since the changes it made to the Metal renderer on macOS could lead to performance regressions on Intel MacBooks. Co-authored-by: Bennet <[email protected]>
**UPDATE**: Response so far seems to be that this fixes the performance issues on Intel MacBooks. So we're going to go ahead and merge it. This reverts the FPS counter added in 1175391 (#16422) because in this issue someone bisected recent performance regressions down to this commit: - #16729 Another issue that's possibly related: - #17305 (comment) We're reverting this in a PR to create a bundle that people can try out. Assets: - Universal Binary: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460781 - x86/Intel: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900461236 - Apple Silicon: https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460978 Release Notes: - Removed the recently-added FPS counter since the changes it made to the Metal renderer on macOS could lead to performance regressions on Intel MacBooks. Co-authored-by: Bennet <[email protected]>
notpeter
changed the title
|
This fix is available in Zed Preview v0.152.1 and Zed Stable v0.151.2. Thanks for everyone who helped track this down and please accept our apologies for the two weeks of battery drain. @amaridev Apologies for hijacking your issue. As the original reporter you reported this on aarch64 while most of the participants in this discussion are seeing what I believe is an Intel x86_64 specific issue. If these builds don't solve your problem, please open a clean issue so we can track that separately. Thanks all! |
Check for existing issues
Describe the bug / provide steps to reproduce it
Hi,
I started to use zed recently and like it pretty much so far. I work a lot with Groovy and Jenkins Pipelines and face some issue with the Groovy plugin, I assume.
I already noticed that the syntax checking and auto format doesn't really work on Groovy files for me. Now I found that Zed sucked my battery empty in less than 2 hours. I am working on a Macbook Pro M1 Max.
I am not sure yet if it's a bug or some problem just on my machine. Hope to get some help figuring out where the issue is.
Environment
Zed: v0.149.5 (Zed)
OS: macOS 14.4.0
Memory: 32 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
If applicable, attach your Zed.log file to this issue.
Zed.log
2024-08-23T07:06:49.767049Z [INFO] ========== starting zed ========== 2024-08-23T07:06:49.769293Z [INFO] Opening main db 2024-08-23T07:06:49.771388Z [INFO] Using git binary path: Some("/Applications/Zed.app/Contents/MacOS/git") 2024-08-23T07:06:49.900457Z [INFO] initializing context server client 2024-08-23T07:06:49.900815Z [INFO] Registering built-in prompt template: content_prompt 2024-08-23T07:06:49.901269Z [INFO] Registering built-in prompt template: edit_workflow 2024-08-23T07:06:49.901599Z [INFO] Registering built-in prompt template: step_resolution 2024-08-23T07:06:49.90204Z [INFO] Registering built-in prompt template: terminal_assistant_prompt 2024-08-23T07:06:49.902292Z [INFO] No prompt template overrides directory found at /Users/maya.scheu/.config/zed/prompt_overrides. Using built-in prompts. 2024-08-23T07:06:49.903934Z [INFO] extensions updated. loading 10, reloading 0, unloading 0 2024-08-23T07:06:49.906914Z [INFO] performance metrics display disabled 2024-08-23T07:06:49.94019Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.940351Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.940448Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.940543Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.94233Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.942405Z [INFO] Opening main db 2024-08-23T07:06:49.942468Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.94254Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.94261Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.942671Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.944152Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.946136Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.948402Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:49.949423Z [INFO] building git repository, `.git` path in the worktree: ".git" 2024-08-23T07:06:50.107595Z [INFO] set status on client 0: Authenticating 2024-08-23T07:06:50.110218Z [INFO] Opening main db 2024-08-23T07:06:50.110291Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.111593Z [INFO] time to first window draw: 345.104167ms 2024-08-23T07:06:50.112028Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.112115Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.114065Z [INFO] set status on client 209727: Connecting 2024-08-23T07:06:50.114313Z [INFO] Node runtime install_if_needed 2024-08-23T07:06:50.115784Z [INFO] Opening main db 2024-08-23T07:06:50.13125Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.132142Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.144327Z [ERROR] No worktree for path: "/Users/maya.scheu/.config/zed/settings.json" 2024-08-23T07:06:50.16959Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.173683Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.228518Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.228604Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.22967Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.229754Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.230491Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.230564Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.231197Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.231273Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.232453Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.232542Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233132Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.23319Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233336Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.233385Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.233428Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233476Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233512Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233555Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233603Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.233646Z [INFO] starting language servers for Groovy: 2024-08-23T07:06:50.2384Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.265558Z [INFO] starting language server. binary path: "/Users/maya.scheu/Library/Application Support/Zed/node/node-v22.5.1-darwin-arm64/bin/node", working directory: "/", args: ["/Users/maya.scheu/Library/Application Support/Zed/copilot/copilot-v0.5.0/dist/agent.js", "--stdio"] 2024-08-23T07:06:50.381445Z [INFO] connected to rpc endpoint https://collab.zed.dev/rpc 2024-08-23T07:06:50.392573Z [INFO] set environment variables from shell:/bin/zsh, path:/Users/maya.scheu/.krew/bin:/opt/homebrew/opt/gawk/libexec/gnubin:/opt/homebrew/opt/gnu-sed/libexec/gnubin:/opt/homebrew/lib/ruby/gems/3.2.0/bin:/opt/homebrew/opt/ruby/bin:/opt/homebrew/opt/libpq/bin:/opt/homebrew/opt/curl/bin:/opt/homebrew/opt/curl/bin:/opt/homebrew/opt/grep/libexec/gnubin:/Users/maya.scheu/.nvm/versions/node/v20.11.0/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin://Applications/Topaz Photo AI.app/Contents/Resources/bin:/Library/Apple/usr/bin:/usr/local/MacGPG2/bin:/Applications/Wireshark.app/Contents/MacOS:/usr/local/share/dotnet:~/.dotnet/tools:/Users/maya.scheu/.krew/bin:/opt/homebrew/opt/gawk/libexec/gnubin:/opt/homebrew/opt/gnu-sed/libexec/gnubin:/opt/homebrew/lib/ruby/gems/3.2.0/bin:/opt/homebrew/opt/ruby/bin:/opt/homebrew/opt/libpq/bin:/opt/homebrew/opt/curl/bin:/opt/homebrew/opt/grep/libexec/gnubin:/Users/maya.scheu/.nvm/versions/node/v20.11.0/bin:/Users/maya.scheu/.sdkman/candidates/maven/current/bin:/Users/maya.scheu/.sdkman/candidates/java/current/bin:/Users/maya.scheu/.sdkman/candidates/groovy/current/bin:/Users/maya.scheu/.sdkman/candidates/gradle/current/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/maya.scheu/Library/Python/3.9/bin:/Users/maya.scheu/.orbstack/bin:/Users/maya.scheu/Library/Application Support/JetBrains/Toolbox/scripts:/Users/maya.scheu/.orbstack/bin:/Users/maya.scheu/Library/Application Support/JetBrains/Toolbox/scripts 2024-08-23T07:06:50.506817Z [INFO] Language server with id 0 sent unhandled notification LogMessage: { "level": 0, "message": "[DEBUG] [agent] [2024-08-23T07:06:50.504Z] Agent service starting", "metadataStr": "[DEBUG] [agent] [2024-08-23T07:06:50.504Z]", "extra": [ "Agent service starting" ] } 2024-08-23T07:06:50.508061Z [INFO] Language server with id 0 sent unhandled notification client/registerCapability: { "registrations": [ { "id": "6e877002-2468-486e-bd36-c57836bc78ef", "method": "workspace/didChangeWorkspaceFolders", "registerOptions": {} } ] } 2024-08-23T07:06:50.733609Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.733668Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:06:50.733709Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.733761Z [INFO] starting language server "groovy", path: "/Users/maya.scheu/workspace/ident-ai/ident-ai_jenkins-shared/", id: 1 2024-08-23T07:06:50.733824Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.733858Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.733893Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.733927Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.733961Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:06:50.734916Z [WARN] request completed with error: failed to connect to the server 2024-08-23T07:06:50.781877Z [INFO] add connection to peer 2024-08-23T07:06:50.781947Z [INFO] add_connection; 2024-08-23T07:06:50.781984Z [INFO] waiting for server hello 2024-08-23T07:06:50.790366Z [INFO] got server hello 2024-08-23T07:06:50.790444Z [INFO] set status to connected (connection id: ConnectionId { owner_id: 0, id: 0 }, peer id: PeerId { owner_id: 499, id: 279372 }) 2024-08-23T07:06:50.79053Z [INFO] set status on client 209727: Connected { peer_id: PeerId { owner_id: 499, id: 279372 }, connection_id: ConnectionId { owner_id: 0, id: 0 } } 2024-08-23T07:06:50.831535Z [INFO] Language server with id 0 sent unhandled notification LogMessage: { "level": 0, "message": "[DEBUG] [agent] [2024-08-23T07:06:50.825Z] Telemetry initialized", "metadataStr": "[DEBUG] [agent] [2024-08-23T07:06:50.825Z]", "extra": [ "Telemetry initialized" ] } 2024-08-23T07:06:50.924377Z [INFO] starting language server. binary path: "/Users/maya.scheu/Library/Application Support/Zed/extensions/work/groovy/groovy-language-server-2884e64/groovy-language-server-macOS/groovy_language_server_wrapper", working directory: "/Users/maya.scheu/workspace/ident-ai/ident-ai_jenkins-shared/", args: [] 2024-08-23T07:07:07.665163Z [INFO] stopping language server groovy 2024-08-23T07:07:07.666232Z [ERROR] oneshot canceled 2024-08-23T07:07:07.666337Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:07:07.666403Z [INFO] starting language server "groovy", path: "/Users/maya.scheu/workspace/ident-ai/ident-ai_jenkins-shared/", id: 2 2024-08-23T07:07:07.66677Z [INFO] starting language server. binary path: "/Users/maya.scheu/Library/Application Support/Zed/extensions/work/groovy/groovy-language-server-2884e64/groovy-language-server-macOS/groovy_language_server_wrapper", working directory: "/Users/maya.scheu/workspace/ident-ai/ident-ai_jenkins-shared/", args: [] 2024-08-23T07:10:16.351996Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:10:16.352092Z [INFO] Initializing default prettier with plugins {} 2024-08-23T07:10:16.352149Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.352207Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.352264Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.352318Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.352372Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.352426Z [INFO] starting language servers for Groovy: groovy 2024-08-23T07:10:16.355746Z [WARN] request completed with error: failed to connect to the serverThe text was updated successfully, but these errors were encountered: