Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous "" in one theme #17273

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Remove extraneous "" in one theme #17273

merged 2 commits into from
Sep 2, 2024

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Sep 2, 2024

Noticed this was an invalid theme. Quick fix to remove extraneous "".

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 2, 2024
@notpeter
Copy link
Member

notpeter commented Sep 2, 2024

That was me in 6b8bdcf.

Sorry!

@notpeter notpeter merged commit c63c201 into main Sep 2, 2024
9 checks passed
@notpeter notpeter deleted the fix-one-theme branch September 2, 2024 18:48
@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 2, 2024

Oh do we need to add these lines back too:

- "border.variant": "#363c46ff",
- "border.focused": "#293b5bff",
+ ""
+ // "border.variant": "#363c46ff",
+ // "border.focused": "#293b5bff",

@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 2, 2024

LOL nevermind I see you added a commit to fix that.

osiewicz pushed a commit to CharlesChen0823/zed that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants