Improve context menu aside layout via custom logic #22154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Presence of the aside no longer affects position of the context menu.
* Prefers to fit to the right, then on same side of line, then other
side of line, within the following preference order:
- Max possible size within text area.
- Max possible size within window.
- Actual size within window. This is the only case that could cause
it to jump around with less stability.
A further enhancement atop this might be to dynamically resize aside height to fit.
Release notes are N/A as they are covered by the notes for #22102.
Closes #8523
Release notes:
* N/A
cla-bot
bot
added
the
cla-signed
If you scroll right it was able to even overflow off the left of the window!
mgsloan
force-pushed
the
improve-context-menu-aside-layout
branch
from
a62fcd0 to
79f15ef
Compare
helgemahrt
pushed a commit
to helgemahrt/zed
that referenced
this pull request
Dec 18, 2024
) * Presence of the aside no longer affects position or size of the context menu. * Prefers to fit to the right, then on same side of line, then other side of line, within the following preference order: - Max possible size within text area. - Max possible size within window. - Actual size within window. This is the only case that could cause it to jump around with less stability. A further enhancement atop this might be to dynamically resize aside height to fit. Release notes are N/A as they are covered by the notes for zed-industries#22102. Closes zed-industries#8523 Release Notes: * N/A
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presence of the aside no longer affects position or size of the context menu.
Prefers to fit to the right, then on same side of line, then other side of line, within the following preference order:
A further enhancement atop this might be to dynamically resize aside height to fit.
Release notes are N/A as they are covered by the notes for #22102.
Closes #8523
Release Notes: