Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Copy Permalink when inside git submodules #23149

Open
1 task done
notpeter opened this issue Jan 14, 2025 · 1 comment
Open
1 task done

Support Copy Permalink when inside git submodules #23149

notpeter opened this issue Jan 14, 2025 · 1 comment
Labels
enhancement [core label] git Git integration feedback

Comments

@notpeter
Copy link
Member

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Steps to reproduce:

  1. Checkout a repo with submodules
  2. Navigate to a file in a submodule
  3. Right click and select "Copy Permalink"
  4. Note error: "Failed to copy permalink: no permalink available"

Explicit steps:

cd ~/code
git clone [email protected]:zed-industries/extensions.git
cd extensions
git submodule init
git submodule update
zed . extensions/zed/assets/keymaps/default-linux.json

Right click and select `Copy Permalink"

Zed Version and System Specs

Zed: v0.170.0 (Zed Nightly 1b3b825)
OS: macOS 15.2.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

2025-01-14T15:08:37.962536-05:00 [ERROR] no permalink available
2025-01-14T15:09:21.746837-05:00 [ERROR] no permalink available
2025-01-14T15:09:27.85251-05:00 [ERROR] no permalink available
2025-01-14T15:09:41.148222-05:00 [ERROR] no permalink available
@notpeter notpeter added bug [core label] git Git integration feedback labels Jan 14, 2025
@notpeter notpeter changed the title Copy Permalink (CopyPermalinkToLine) doesn't work in git submodules Support Copy Permalink when inside git submodules Jan 14, 2025
@notpeter notpeter added enhancement [core label] and removed bug [core label] labels Jan 14, 2025
@0xtimsb
Copy link
Contributor

0xtimsb commented Jan 19, 2025

Hey, @notpeter, in your steps to reproduce, I think you missed the .gitmodules file at the root of the project.

I have a site where the data directory is a submodule, and the copy permalink works in it.

[submodule "src/data"]
	path = src/data
	url = [email protected]:0xtimsb/site-data.git

source: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] git Git integration feedback
Projects
None yet
Development

No branches or pull requests

2 participants