Newline indentation does not follow my tab size setting (in a svelte file)

[thelegendtubaguy]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

In a .svelte file with a typescript script block, Zed doesn't appear to be respecting my tab size setting. I have tab_size set at the root of my settings.json to 4.

Environment

Zed: v0.119.20 (Zed)
OS: macOS 13.6.1
Memory: 32 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

In these two screenshots, I have a basic if block. I've hit enter to go to the first line inside the block and hit tab 1 time. Zed seems to indent 2 spaces instead of my setting of 4.

This is what it looks like if I hit enter and hit space 4 times:

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[reandov]

I'm also having this problem, really strange

[lthoerner]

This is still a bug, but here is a workaround for now. Use .prettierrc to set "tabWidth": 4, or "useTabs": true, depending on whether you want to use tabs or spaces. Then manually set "tab_width": 4 in Zed's settings.json. This issue seems to arise from a conflict with Prettier's formatting.

[matubu]

It is possible to change this option inside of the svelte extension code by adding this inside the zed::Extension implementation

    fn language_server_workspace_configuration(
        &mut self,
        _language_server_id: &zed_extension_api::LanguageServerId,
        _worktree: &zed_extension_api::Worktree,
    ) -> Result<Option<serde_json::Value>> {
        Ok(Some(serde_json::json!({
            "prettier": {
                "useTabs": true,
                "tabWidth": 4,
            }
        })))
    }

But it seems like extensions can't currently access user preference for formatting options. I think it's something the extensions should have access to.

[bdkjones]

I have the same issue editing PHP files. The first tab is always 2 spaces, then subsequent tabs are 4. So I have to hit tab, tab, and then backspace twice to get my desired indentation.

I've already tried setting "tab_width" in my settings and I'm set to use spaces instead of tabs. Zed is unusable until this is fixed.

[shirshak55]

I am also facing similar issue. I think formatting isn't polished yet.

The intention line should be 4 space. I have set it up in prettierrc file also. Also, it would be nice to see if there are no logs of prettier, as some prettier settings aren't being applied.