Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Adapt recent upstream ReplaceMenuProvider changes #289

Closed
pinussilvestrus opened this issue Jan 29, 2021 · 1 comment
Closed

Adapt recent upstream ReplaceMenuProvider changes #289

pinussilvestrus opened this issue Jan 29, 2021 · 1 comment

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Jan 29, 2021

Is your feature request related to a problem? Please describe.

Inside the Zeebe Modeler, we override the basic replace menu provider with a custom one. However, if we would like to upgrade bpmn-js@8, we would run into errors because of breaking changes.

export default function ReplaceMenuProvider(
    bpmnFactory, popupMenu, modeling, moddle,
    bpmnReplace, rules, translate) {

Describe the solution you'd like

Update the custom replace menu to handle this while upgrading to bpmn-js@8.

Describe alternatives you've considered

Don't use inheritance but create a proper new provider

export default class ReplaceMenuProvider {

  constructor(popupMenu) {
    popupMenu.registerProvider('bpmn-replace', this);
  }

  getPopupMenuEntries(element) {
    return function(entries) {
      // ...
    };
}

ReplaceMenuProvider.$inject = ['popupMenu'];

==> We will likely do it on the fly while fixing #288.

Additional context

Related to #288

@pinussilvestrus pinussilvestrus changed the title Adapt recent downstream ReplaceMenuProvider changes Adapt recent upstream ReplaceMenuProvider changes Jan 29, 2021
@pinussilvestrus
Copy link
Contributor Author

Fixed alongside #288. Let's close the issue on this side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant