Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Helm chart does not allow mounting TLS certificates #3268

Open
1 task done
mazay opened this issue Dec 18, 2024 · 7 comments
Open
1 task done

[BUG]: Helm chart does not allow mounting TLS certificates #3268

mazay opened this issue Dec 18, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mazay
Copy link

mazay commented Dec 18, 2024

Contact Details [Optional]

No response

System Information

Helm chart version 0.71.0

What happened?

The Helm chart does not support mounting TLS certificates for using MySQL SSL encrypted connections.

The docs suggest adding certificates to the chart root, which is not feasible - we should not repackage the helm chart to enable such simple functionality.

Alternatively, the app could use the CA certificates already available on the pod, eg. /etc/ssl/certs/ca-certificates.crt when ?ssl=true or a similar argument is present in the DB connection URL.

At the moment we had to make SSL encryption optional and sacrifice the security.

Reproduction steps

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mazay mazay added the bug Something isn't working label Dec 18, 2024
@htahir1
Copy link
Contributor

htahir1 commented Dec 19, 2024

@stefannica wdyt? We might consider customizing the Helm chart to mount the existing CA certificates directory from the pod into the application container. This would allow the application to use the pre-existing certificates without needing to repackage the Helm chart.

@stefannica
Copy link
Contributor

Giving this a try here: #3268

@stefannica
Copy link
Contributor

stefannica commented Feb 4, 2025

@mazay this should have been fixed with #3320. Please confirm and then close this issue when convenient.

The ZenML server can now use CA certificates already available on the pod in /etc/ssl/certs/ca-certificates.crt when ?ssl=true is present in the DB connection URL or set individually by setting the zenml.database.ssl: true Helm chart value. The CA certificate can also be injected globally at container level using zenml.certificates.

@mazay
Copy link
Author

mazay commented Feb 4, 2025

@stefannica thanks. Do you plan on releasing this?

@stefannica
Copy link
Contributor

@stefannica thanks. Do you plan on releasing this?

It will be in the next ZenML release, of course. I can't back-port it however, because it relies on some code changes too.

@mazay
Copy link
Author

mazay commented Feb 4, 2025

@stefannica ok, we use helm artifact for deployment. So I can't test it until it's released

@stefannica
Copy link
Contributor

@stefannica ok, we use helm artifact for deployment. So I can't test it until it's released

@mazay the new Helm chart version (0.74.0) has just been published: https://artifacthub.io/packages/helm/zenml/zenml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants