Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark results "Unexpected" #5

Open
baigd opened this issue Jan 21, 2019 · 1 comment
Open

Benchmark results "Unexpected" #5

baigd opened this issue Jan 21, 2019 · 1 comment

Comments

@baigd
Copy link

baigd commented Jan 21, 2019

Hi Zhoulai,

I had a trial of Xsat on the Benchmarks (Table 1 of Xsat paper), but got incorrect (unexpected) results on (6), (7), (8), (14), (16), (17), (18), (19), (23), (29), (30). I have looked into the generated foo.c and found the floating-point constants are not parsed correctly. I anticipate there may be some problem in the parsing process. I have tried to run Xsat with Docker, and the problem remains. Do you have any suggestion on the location I can fix it?

Thanks!

@zhoulaifu
Copy link
Owner

Thanks for pointing out the issue. It looks like a regression. Not sure if it has anything to do with the new Z3 or sympy frontends.

I hacked the FP parsing parts here: https://github.com/zhoulaifu/xsat/blob/master/xsat_gen.py#L147. It was quick and dirty; a more robust parsing should have be used. I am working on other projects now, but will maintain the repo later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants